724670 - Results in search do not appear in report/list

Status: VERIFIED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[[DEACTIVATED] Adrian Gaudebert]

Raised by KaiRo: 

https://crash-stats.mozilla.com/query/query?product=FennecAndroid&version=FennecAndroid%3A13.0a1&range_value=1&range_unit=weeks&date=02%2F06%2F2012+22%3A52%3A53&query_search=signature&query_type=contains&query=Unable+to+start+activity&reason=&build_id=&process_type=any&hang_type=any&do_query=1#

When clicking on a signature, report/list says there is no report for those parameters. E.g.: https://crash-stats.mozilla.com/report/list?signature=java.lang.RuntimeException%3A%20Unable%20to%20start%20activity%20ComponentInfo{org.mozilla.fennec%2Forg.mozilla.fennec.App}%3A%20java.lang.IllegalArgumentException%3A%20bad%20base-64%3A%20at%20android.app.ActivityThread.performLaunchActivity%28ActivityThread.java%29

Comment 1

[Robert Kaiser]

Thanks for filing. This has been originally raised by kbrosnan, so adding him.
I wonder if the issue is connected to bug 721169 somehow.

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

(In reply to Robert Kaiser (:[e-mail]) from comment #1)
> I wonder if the issue is connected to bug 721169 somehow.

It shouldn't, bug 721169 is focused on a difference between TCBS and search. Since 2.4.1 search and report/list use the same code base, so a difference there is likely due to something else. 

I cannot reproduce in my VM yet, I'll have to wait for a fresh DB dump. Moving to 2.4.3.

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

This problem is due to slashes ('/') in signatures. As Apache doesn't accept them and raise an error, we double-encode them in the UI before calling any URL. The problem is that at some point, I removed the decoding part in the middleware. I just need to add that again and it should come back to normal.

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/376

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ff690a921b321f031878fed310e1044eabe3c5e7
Merge pull request #376 from AdrianGaudebert/724670-fix-slashes-in-signatures

Fixes bug 724670 - Decode double encoded slashes in terms and signature ...

Comment 7

[[DEACTIVATED] Adrian Gaudebert]

Steps to QA
-----------

1. Go to advanced search.
2. Search for a signature containing a slash ('/'). Example: search for signatures containing "java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fennec/org.mozilla.fennec.App}"
3. Check that there are results.
4. Click on a signature to go to report/list.
5. Check that there are results.

Comment 8

[[DEACTIVATED] Adrian Gaudebert]

Note about step 2. in previous comment: this signature exists only for FennecAndroid, make sure to select that product. 

If no result is raised by that previous search, search for signatures containing "/" and continue.

Comment 9

[Matt Brandt [:mbrandt]]

QA verified on stage:

Searching for slashes returns results:
https://crash-stats.allizom.org/query/query?product=FennecAndroid&version=ALL%3AALL&range_value=3&range_unit=weeks&date=02%2F27%2F2012+19%3A14%3A28&query_search=signature&query_type=contains&query=mozilla.fennec%2Forg&reason=&build_id=&process_type=any&hang_type=any&do_query=1

https://crash-stats.allizom.org/query/query?product=FennecAndroid&version=ALL%3AALL&range_value=3&range_unit=weeks&date=02%2F27%2F2012+19%3A14%3A28&query_search=signature&query_type=contains&query=%2F&reason=&build_id=&process_type=any&hang_type=any&do_query=1

From bug 725313 - this search now works (thx nhirata)
https://crash-stats.allizom.org/report/list?range_value=7&range_unit=days&date=2012-02-21&signature=java.lang.RuntimeException%3A%20Unable%20to%20resume%20activity%20{org.mozilla.fennec%2Forg.mozilla.fennec.App}%3A%20java.lang.RuntimeException%3A%20Failure%20delivering%20result%20ResultInfo{who%3Dnull%2C%20request%3D2%2C%20result%3D-1%2C%20data%3DIntent%20{%20%28has%20extras%29%20}}%20to%20activity%20{org.mozilla.f...&version=FennecAndroid%3A13.0a1