Closed Bug 724776 Opened 8 years ago Closed 8 years ago

Selecting a Character Encoding throws a ReferenceError: SetForcedCharset is not defined

Categories

(Core :: Internationalization, defect)

12 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13
Tracking Status
firefox12 + verified

People

(Reporter: blackrazor.qa, Assigned: smontagu)

References

Details

(Keywords: regression, Whiteboard: [qa+])

Attachments

(2 files)

Attached file charset_error.docx
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Build ID: 20120129021758

Steps to reproduce:

Click View -> Character Encoding -> More Encodings -> East Asian -> Chinese Simplified (GB2312).


Actual results:

A JS error was thrown: ReferenceError: SetForcedCharset is not defined.
Bug was encountered in FF12/Aurora but filed using FF10. My apologies for any confusion.
Regression window(m-i)
Works:
http://hg.mozilla.org/integration/mozilla-inbound/rev/388edf50e323
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120123 Firefox/12.0a1 ID:20120124003851
Fails:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f173a9a1e056
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120124 Firefox/12.0a1 ID:20120124015351
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=388edf50e323&tochange=f173a9a1e056

Suspected: Bug 720310
Blocks: 720310
Status: UNCONFIRMED → NEW
Component: Untriaged → Internationalization
Ever confirmed: true
Keywords: regression
OS: Windows 7 → All
Product: Firefox → Core
QA Contact: untriaged → i18n
Hardware: x86_64 → All
Ouch, I changed one call to SetForcedCharset to BrowserSetForcedCharacterSet and missed another one 5 lines below even though it's staring me in the face at https://bugzilla.mozilla.org/attachment.cgi?id=590816&action=diff#a/browser/base/content/browser.js_sec1
Attached patch PatchSplinter Review
Assignee: nobody → smontagu
Attachment #594923 - Flags: review?(gavin.sharp)
Attachment #594923 - Flags: review?(gavin.sharp) → review+
We really should have tests for all of this stuff.
We need to fix this for 12.
https://hg.mozilla.org/mozilla-central/rev/6b3f68d98dcd
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 594923 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): 720310
User impact if declined: Unable to override page encoding in some scenarios
Testing completed (on m-c, etc.): On m-c since 2012-02-08
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #594923 - Flags: approval-mozilla-aurora?
Attachment #594923 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [qa+]
I have verified this on:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20100101 Firefox/12.0 beta 5
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0 beta 5
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0 beta 5

When following the steps from the description, no error are triggered.
On Ubuntu I've got some warnings but still no error. Is this intended?

Setting resolution to Verified.
(In reply to Vlad [QA] from comment #11)
> On Ubuntu I've got some warnings but still no error. Is this intended?

What warnings exactly?
There are no more warnings on a new profile.
(In reply to Vlad [QA] from comment #13)
> There are no more warnings on a new profile.

Thanks Vlad, can you verify on Firefox 13 as well so we can close this one out?
You need to log in before you can comment on or make changes to this bug.