Add the missing nsIObserver interface to nsSmsManager

RESOLVED FIXED in mozilla13

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vingtetun, Assigned: mounir)

Tracking

Trunk
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 595003 [details] [diff] [review]
Patch
Attachment #595003 - Flags: review?(blassey.bugs)
(Assignee)

Comment 2

5 years ago
Comment on attachment 595003 [details] [diff] [review]
Patch

Review of attachment 595003 [details] [diff] [review]:
-----------------------------------------------------------------

This has nothing to do with Android.
Wonder why you asked the review to an Android peer....
Attachment #595003 - Flags: review?(blassey.bugs) → review?(bugs)
(Assignee)

Comment 3

5 years ago
For a bit of context: I wrote that patch but on Vivien's laptop, that's why he did attach it but the patch has my name.
For more context, this patch fix an assertion that I hit when running Gaia's tests.
(Assignee)

Updated

5 years ago
Component: General → DOM
OS: Android → All
QA Contact: general → general
Hardware: ARM → All

Comment 5

5 years ago
Comment on attachment 595003 [details] [diff] [review]
Patch

Why wasn't this noticed before?
Attachment #595003 - Flags: review?(bugs) → review+
(Assignee)

Comment 6

5 years ago
Comment on attachment 595003 [details] [diff] [review]
Patch

I don't know why I haven't seen that during my tests. I guess the assert must have been lost in the logcat spam. Things seemed to work though.
Attachment #595003 - Flags: checkin+

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5c587c490cd7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.