Note: There are a few cases of duplicates in user autocompletion which are being worked on.

perfprobe.cpp doesn't compile on mingw

RESOLVED FIXED in mozilla13

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla13
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 595011 [details] [diff] [review]
fix v1.0

GCC doesn't accept friend statement without class keyword. Also mingw doesn't provide __in macro because it would conflict with std headers. Since they are no-op, removing them won't harm.

This I was at this, I've also fixed warnings about constructor initialization order and pointer to integer cast (TRACEHANDLE is an integer, while NULL is a pointer).
Attachment #595011 - Flags: review?(dteller)
Comment on attachment 595011 [details] [diff] [review]
fix v1.0

Review of attachment 595011 [details] [diff] [review]:
-----------------------------------------------------------------

Interesting. You have my r+ provided it passes TryServer.
Interestingly, I have not noticed any warnings when compiling with VS2010.
Attachment #595011 - Flags: review?(dteller) → review+
(Assignee)

Comment 2

6 years ago
(In reply to David Rajchenbach Teller [:Yoric] from comment #1)
> Interesting. You have my r+ provided it passes TryServer.

Passed here: https://tbpl.mozilla.org/?tree=Try&rev=4c6837e03594

> Interestingly, I have not noticed any warnings when compiling with VS2010.

VS is generally less strict about that stuff (at least by default).

Thanks for the review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/537e79b20314
Whiteboard: [inbound]
Thank you for the (very quick) fix.

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/537e79b20314

\o/
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.