724864 - perfprobe.cpp doesn't compile on mingw

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

GCC doesn't accept friend statement without class keyword. Also mingw doesn't provide __in macro because it would conflict with std headers. Since they are no-op, removing them won't harm.

This I was at this, I've also fixed warnings about constructor initialization order and pointer to integer cast (TRACEHANDLE is an integer, while NULL is a pointer).

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 595011 [details] [diff] [review]
fix v1.0

Review of attachment 595011 [details] [diff] [review]:
-----------------------------------------------------------------

Interesting. You have my r+ provided it passes TryServer.
Interestingly, I have not noticed any warnings when compiling with VS2010.

Comment 2

[Jacek Caban]

(In reply to David Rajchenbach Teller [:Yoric] from comment #1)
> Interesting. You have my r+ provided it passes TryServer.

Passed here: https://tbpl.mozilla.org/?tree=Try&rev=4c6837e03594

> Interestingly, I have not noticed any warnings when compiling with VS2010.

VS is generally less strict about that stuff (at least by default).

Thanks for the review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/537e79b20314

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Thank you for the (very quick) fix.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/537e79b20314

\o/