Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Push images from plugins instead of pulling from nsObjectFrame

RESOLVED FIXED in mozilla13

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bas, Assigned: bas)

Tracking

unspecified
mozilla13
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
As we progress om making the NPAPI Async extension work, we need to push images from the plugin code rather than pulling them from nsObjectFrame. That way the plugin code can also update the images on the container as new surfaces are set current.

Now that the refactoring of image containers is done so that they are layermanager independent we can do this.
(Assignee)

Comment 1

6 years ago
Created attachment 595105 [details] [diff] [review]
Push images instead of pulling

This patch should do the trick, the MacIOSurface path could be made to work a little bit more optimal now that we push instead of pull, but since this shouldn't cause any regressions I suggest we do that in a followup.
Attachment #595105 - Flags: review?(roc)
Comment on attachment 595105 [details] [diff] [review]
Push images instead of pulling

Review of attachment 595105 [details] [diff] [review]:
-----------------------------------------------------------------

Nice

::: dom/plugins/ipc/PluginInstanceParent.h
@@ +299,5 @@
>      // |aSize|.  Return true if successful.
>      bool CreateBackground(const nsIntSize& aSize);
>      void DestroyBackground();
>      SurfaceDescriptor BackgroundDescriptor() /*const*/;
> +    mozilla::layers::ImageContainer *GetImageContainer();

Add a typedef to make this prefixing go away
Attachment #595105 - Flags: review?(roc) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 595316 [details] [diff] [review]
Push images instead of pulling v2

Some issues found during testing were fixed. We now deal with an instance going away due to plugin crashing causing no container to be found, and some of the mac code was fixed up to compile/behave correctly.
Attachment #595105 - Attachment is obsolete: true
Attachment #595316 - Flags: review?(roc)
Attachment #595316 - Flags: review?(roc) → review+

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/1a345b043b47
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Depends on: 733323
No longer depends on: 733323
Depends on: 777946
You need to log in before you can comment on or make changes to this bug.