Closed Bug 725000 Opened 8 years ago Closed 8 years ago

IonMonkey: Assertion failure: input->type() == MIRType_Int32, at ion/Lowering.cpp:354

Categories

(Core :: JavaScript Engine, defect, major)

Other Branch
x86_64
Linux
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: decoder, Assigned: dvander)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(1 file)

The following testcase asserts on ionmonkey revision c34398f961e7 (run with --ion -n), tested on 64 bit:


function printBugNumber (num) {}
(function(){for(j=02 ;j<3;~ printBugNumber)NaN=42})();
Attached patch fixSplinter Review
We needed an unspecialized version of BitNot.
Assignee: general → dvander
Status: NEW → ASSIGNED
Attachment #595573 - Flags: review?
Attachment #595573 - Flags: review? → review?(sstangl)
Comment on attachment 595573 [details] [diff] [review]
fix

Review of attachment 595573 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/Trampoline-arm.cpp
@@ +591,2 @@
>          outReg = regs.takeAny();
> +        masm.reserveStack(sizeof(int));

for consistency with freeStack() below, |int32|?

::: js/src/ion/x64/Trampoline-x64.cpp
@@ +517,2 @@
>          outReg = regs.takeAny();
> +        masm.reserveStack(sizeof(int));

int32?

@@ +596,2 @@
>          masm.load32(Address(esp, 0), ReturnReg);
> +        masm.freeStack(sizeof(int));

int32?
Attachment #595573 - Flags: review?(sstangl) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/1ae79ea16a74

Nits pushed in a follow-up fix.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
A testcase for this bug was automatically identified at js/src/jit-test/tests/ion/bug725000.js.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.