725000 - IonMonkey: Assertion failure: input->type() == MIRType_Int32, at ion/Lowering.cpp:354

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

The following testcase asserts on ionmonkey revision c34398f961e7 (run with --ion -n), tested on 64 bit:


function printBugNumber (num) {}
(function(){for(j=02 ;j<3;~ printBugNumber)NaN=42})();

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

We needed an unspecialized version of BitNot.

Comment 2

[Sean Stangl [:sstangl]]

Comment on attachment 595573 [details] [diff] [review]
fix

Review of attachment 595573 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/Trampoline-arm.cpp
@@ +591,2 @@
>          outReg = regs.takeAny();
> +        masm.reserveStack(sizeof(int));

for consistency with freeStack() below, |int32|?

::: js/src/ion/x64/Trampoline-x64.cpp
@@ +517,2 @@
>          outReg = regs.takeAny();
> +        masm.reserveStack(sizeof(int));

int32?

@@ +596,2 @@
>          masm.load32(Address(esp, 0), ReturnReg);
> +        masm.freeStack(sizeof(int));

int32?

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/projects/ionmonkey/rev/1ae79ea16a74

Nits pushed in a follow-up fix.

Comment 4

[Christian Holler (:decoder)]

A testcase for this bug was automatically identified at js/src/jit-test/tests/ion/bug725000.js.