725056 - JavaScript Warning: "function get_test_plugin does not always return a value" {file: "chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js" line: 14}

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P4)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1328632854.1328639066.12467.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/02/07 08:40:54
{
TEST-INFO | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | Console message: [JavaScript Warning: "function get_test_plugin does not always return a value" {file: "chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js" line: 14}]
}

SM simply copies FF code, which is missing an ending "return <something>;".

Comment 1

[Serge Gautherie (:sgautherie)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=9384818&tree=Firefox&full=1
Rev3 Fedora 12x64 mozilla-central debug test mochitest-other on 2012-02-16 04:30:20 PST for push 6989376471f7
{
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Console message: [JavaScript Warning: "function get_test_plugin does not always return a value" {file: "chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js" line: 7}]
}

Comment 2

[Georg Fritzsche [:gfritzsche]]

Not seen anymore.

Comment 3

[Serge Gautherie (:sgautherie)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=39515476&tree=Mozilla-Central
Ubuntu VM 12.04 x64 mozilla-central debug test mochitest-browser-chrome-1 on 2014-05-12 14:15:56 PDT for push b1c9fcb5450b
{
14:32:48     INFO -  TEST-START | chrome://mochitests/content/browser/browser/base/content/test/plugins/browser_pluginnotification.js
[...]
14:33:12     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/plugins/browser_pluginnotification.js | finished in 23667ms
}
No more "get_test_plugin" warning :-)

(By code inspection,)
Bug 776208 fixed this for Firefox. Then bug 773761 fixed it for SeaMonkey.

V.Fixed.