Last Comment Bug 725105 - Fix non-OS-double-buffered GL layers
: Fix non-OS-double-buffered GL layers
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Mac OS X
-- normal (vote)
: mozilla15
Assigned To: Joe Drew (not getting mail)
: Milan Sreckovic [:milan]
Depends on:
  Show dependency treegraph
Reported: 2012-02-07 14:42 PST by Joe Drew (not getting mail)
Modified: 2012-05-08 03:17 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Invert texture coordinates (1.49 KB, patch)
2012-02-07 14:42 PST, Joe Drew (not getting mail)
jacob.benoit.1: review+
Details | Diff | Splinter Review

Description User image Joe Drew (not getting mail) 2012-02-07 14:42:28 PST
Created attachment 595192 [details] [diff] [review]
Invert texture coordinates

The single-buffering path is broken right now, but this fixes it.
Comment 1 User image Benoit Jacob [:bjacob] (mostly away) 2012-02-07 18:26:04 PST
You rock! Does non-OS-double-buffering work on B2G with that patch?
Comment 2 User image Joe Drew (not getting mail) 2012-02-07 18:34:41 PST
Not really, unfortunately. We still get some bad rendering. More investigation is necessary.
Comment 3 User image Andreas Gal :gal 2012-02-13 11:29:14 PST
Oh wow this could be great. Can you test switching off double buffering by flipping that bool and applying this patch? We desperately need that to stop tearing.
Comment 4 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-02-13 11:29:31 PST
We need this patch as insurance against what appear to be driver bugs, so it's quite high priority for b2g.  What's the status here?  Not ready for review yet?
Comment 5 User image Joe Drew (not getting mail) 2012-02-13 12:59:21 PST
Note that even if you apply this patch, you still need to turn off double buffering at GLContextProviderEGL.cpp:2016 before it'll take effect.
Comment 6 User image Joe Drew (not getting mail) 2012-02-13 15:33:53 PST
Finally got a test build up on the Maguro device while using single buffering. Still shows problems (flashing the lock screen this time), which implies that the problem is a fundamental one involving FBOs on the Maguro's drivers.
Comment 7 User image Benoit Jacob [:bjacob] (mostly away) 2012-02-18 11:20:34 PST
Comment on attachment 595192 [details] [diff] [review]
Invert texture coordinates

Review of attachment 595192 [details] [diff] [review]:

Sorry, I apparently forgot to r+ this.
Comment 8 User image Joe Drew (not getting mail) 2012-05-07 14:55:34 PDT
Comment 9 User image Ed Morley [:emorley] 2012-05-08 03:17:41 PDT

Note You need to log in before you can comment on or make changes to this bug.