The default bug view has changed. See this FAQ.

tidy up formal access, remove dead Stack code

RESOLVED FIXED in mozilla13

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Just flushing out some built-up cleanup patches from farther-out patches.
(Assignee)

Comment 1

5 years ago
Created attachment 595235 [details] [diff] [review]
tidy up Stack

This patch
 - undoes more of the changes from the old Stack/StackSpace split,
 - removes resetCallFrame; it is dead (didn't I already do this?)
 - kills these initJitFrame* functions since they don't actually describe what the prologue is doing anymore, merging two of them into initFixupFrame, since that is actually used (by getFixupFrame in FixupArity).
Attachment #595235 - Flags: review?(bhackett1024)
(Assignee)

Comment 2

5 years ago
Created attachment 595236 [details] [diff] [review]
simplify Interpret args/local ops

Tiny patch, just uses formalArg (useful later when arg access is more dynamic) and adds localSlot for symmetry.
Attachment #595236 - Flags: review?(bhackett1024)
Attachment #595235 - Flags: review?(bhackett1024) → review+
Attachment #595236 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ede0c5fcdbad
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d6b0f4c1bc0
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/ede0c5fcdbad
https://hg.mozilla.org/mozilla-central/rev/7d6b0f4c1bc0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.