Closed Bug 725138 Opened 12 years ago Closed 12 years ago

tidy up formal access, remove dead Stack code

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(2 files)

Just flushing out some built-up cleanup patches from farther-out patches.
Attached patch tidy up StackSplinter Review
This patch
 - undoes more of the changes from the old Stack/StackSpace split,
 - removes resetCallFrame; it is dead (didn't I already do this?)
 - kills these initJitFrame* functions since they don't actually describe what the prologue is doing anymore, merging two of them into initFixupFrame, since that is actually used (by getFixupFrame in FixupArity).
Attachment #595235 - Flags: review?(bhackett1024)
Tiny patch, just uses formalArg (useful later when arg access is more dynamic) and adds localSlot for symmetry.
Attachment #595236 - Flags: review?(bhackett1024)
Attachment #595235 - Flags: review?(bhackett1024) → review+
Attachment #595236 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/ede0c5fcdbad
https://hg.mozilla.org/mozilla-central/rev/7d6b0f4c1bc0
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: