725155 - Move MozillaMaintenance service description string to Strings section of ini file

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

This bug is to move the localization strings for the service description.

Axel Hecht [:Pike] wrote:
::: browser/locales/en-US/updater/updater.ini
@@ +4,5 @@
>  TitleText=%MOZ_APP_DISPLAYNAME% Update
>  InfoText=%MOZ_APP_DISPLAYNAME% is installing your updates and will start in a few moments…
> +
> +[MaintenanceServiceStrings]
> +ServiceDescription=The Mozilla Maintenance Service ensures that you have the latest and most secure version of Mozilla Firefox on your computer. Keeping Firefox up to date is very important for your online security, and Mozilla strongly recommends that you keep this service enabled.

Can we move this up to [Strings]?

Sadly, compare-locales isn't built out to support more than one section per ini file, see also bug 725064.  

I'm posting this bug because bug 725064 seems like an infrastructure improvement bug, but this bug is a specific work around for this particular case.

Comment 1

[Axel Hecht [:Pike]]

Thanks.

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 595411 [details] [diff] [review]
Patch v1.

Review of attachment 595411 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good to me, feedback+. Should still get the real review from Rob, of course.

Comment 4

[Brian R. Bondy [:bbondy]]

Thanks for the feedback pass on it :)

Comment 5

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/42a688ff9cf5

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/42a688ff9cf5