Closed
Bug 725199
Opened 13 years ago
Closed 13 years ago
include build machine name in about:buildconfig
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla13
People
(Reporter: jhford, Assigned: jhford)
Details
Attachments
(1 file, 1 obsolete file)
|
791 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
It'd be cool, at least for me, to have the non-qualified hostname for the machine that built firefox available in about:buildconfig. I'll try to write up a patch at some point in the future.
|
Assignee | |
Comment 1•13 years ago
|
||
Adding this information makes life easier for me, especially when dealing with updates on new platforms.
|
|
Assignee | |
Comment 2•13 years ago
|
||
I had originally had just "<p>Built by "@BUILD_HOSTNAME@"", but forgot to clean up a quote when switching to an h2.
this results in:
<body class="aboutPageWideContainer">
<h1>about:buildconfig</h1>
<h2>Build Machine</h2>
<p>jhford-wifi</p>
<h2>Source</h2>
<p>Built from <a href="http://hg.mozilla.org/mozilla-central/rev/b45785802731">http://hg.mozilla.org/mozilla-central/rev/b45785802731</a></p>
<h2>Build platform</h2>
Attachment #595310 -
Attachment is obsolete: true
Attachment #595310 -
Flags: review?(ted.mielczarek)
Attachment #595311 -
Flags: review?(ted.mielczarek)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 595311 [details] [diff] [review]
silly typos
A few reasons for not doing this:
* Its unlikely useful for 99.999% of our users, while at least about:buildconfig has actual use elsewhere.
* A given build can happen on multiple machines, (build on one, l10n repack on another, etc.)
* Local developers who wish to share a build may expose their local hostname to people, which could be a security risk in some circumstances (imo.)
Opinion on the approach:
* I think if we do it, we should use ifdef MOZILLA_OFFICIAL for even showing this
* also change it from "Build Machine" to "Built on @VENDOR_NAME@'s Machine"
* Instead of doing BUILD_HOSTNAME as a shell expansion in this makefile (which might get called multiple times per build) how about generating the value in configure and using it directly (it is unlikely to change from one build to another to make caching of autoconf.mk still work fine)
I'm r-'ing for the actual error of not closing your ifdef in toolkit/content/buildconfig.html
I'll leave the other points up to you/ted though, since I'm not technically a reviewer here.
Attachment #595311 -
Flags: review-
|
|
Assignee | |
Updated•13 years ago
|
Attachment #595311 -
Flags: review?(ted.mielczarek)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 595311 [details] [diff] [review]
silly typos
Review of attachment 595311 [details] [diff] [review]:
-----------------------------------------------------------------
This seems useful.
::: toolkit/content/Makefile.in
@@ +77,4 @@
> DEFINES += -DSOURCE_REPO="$(SOURCE_REPO)"
> endif
>
> +BUILD_HOSTNAME := $(shell hostname)
I'd actually just use = here, so this only gets evaluated on-demand. (:= is better when you're going to use the variable value multiple times, but here you're only using it once anyway.)
::: toolkit/content/buildconfig.html
@@ +58,5 @@
> <body class="aboutPageWideContainer">
> <h1>about:buildconfig</h1>
> +#ifdef BUILD_HOSTNAME
> +<h2>Build Machine</h2>
> +<p>@BUILD_HOSTNAME@</p>
You forgot an #endif here.
Attachment #595311 -
Flags: review- → review+
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•