Enable and fix assertions in linker code

RESOLVED FIXED in mozilla13

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla13
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

8 years ago
The linker has a bunch of commented out assertions in wait for mfbt to stop using JS_Assert. Some of them are logically backwards, so fix them, too.
Assignee

Comment 1

8 years ago
The mozglue/linker/ElfLoader.cpp change is because I was getting an assertion because of refcounting. That made me realize that deleting these objects actually does dlclose(), which is what we wanted to avoid in the first place (see comment earlier in ~ElfLoader).
Attachment #595350 - Flags: review?
Assignee

Comment 2

8 years ago
Comment on attachment 595350 [details] [diff] [review]
Enable and fix assertions in linker code

See comment 1.
Attachment #595350 - Flags: review? → review?(taras.mozilla)
Assignee

Comment 3

8 years ago
Attachment #595398 - Flags: review?(taras.mozilla)
Assignee

Updated

8 years ago
Attachment #595350 - Attachment is obsolete: true
Attachment #595350 - Flags: review?(taras.mozilla)
Assignee

Comment 4

8 years ago
Comment on attachment 595398 [details] [diff] [review]
Enable and fix assertions in linker code

There are some problems arisen by these assertions that need some fixing first.
Attachment #595398 - Flags: review?(taras.mozilla)
Assignee

Comment 5

8 years ago
I was getting assertions on refcounting for zips from APKOpen.cpp. MFBT doesn't really support non-refcounted instantiation.
Attachment #595447 - Flags: review?(taras.mozilla)
Assignee

Updated

8 years ago
Attachment #595398 - Attachment is obsolete: true

Updated

8 years ago
Attachment #595447 - Flags: review?(taras.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/91d77c934b26
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.