The linker has a bunch of commented out assertions in wait for mfbt to stop using JS_Assert. Some of them are logically backwards, so fix them, too.
The mozglue/linker/ElfLoader.cpp change is because I was getting an assertion because of refcounting. That made me realize that deleting these objects actually does dlclose(), which is what we wanted to avoid in the first place (see comment earlier in ~ElfLoader).
Attachment #595350 - Flags: review?
Comment on attachment 595350 [details] [diff] [review] Enable and fix assertions in linker code See comment 1.
Attachment #595350 - Flags: review? → review?(taras.mozilla)
Comment on attachment 595398 [details] [diff] [review] Enable and fix assertions in linker code There are some problems arisen by these assertions that need some fixing first.
I was getting assertions on refcounting for zips from APKOpen.cpp. MFBT doesn't really support non-refcounted instantiation.
Attachment #595447 - Flags: review?(taras.mozilla)
Attachment #595398 - Attachment is obsolete: true
Attachment #595447 - Flags: review?(taras.mozilla) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.