725230 - Enable and fix assertions in linker code

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[Mike Hommey [:glandium]]

The linker has a bunch of commented out assertions in wait for mfbt to stop using JS_Assert. Some of them are logically backwards, so fix them, too.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Enable and fix assertions in linker code

The mozglue/linker/ElfLoader.cpp change is because I was getting an assertion because of refcounting. That made me realize that deleting these objects actually does dlclose(), which is what we wanted to avoid in the first place (see comment earlier in ~ElfLoader).

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 595350 [details] [diff] [review]
Enable and fix assertions in linker code

See comment 1.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Enable and fix assertions in linker code

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 595398 [details] [diff] [review]
Enable and fix assertions in linker code

There are some problems arisen by these assertions that need some fixing first.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Enable and fix assertions in linker code

I was getting assertions on refcounting for zips from APKOpen.cpp. MFBT doesn't really support non-refcounted instantiation.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78941a969e20

Comment 7

[Mike Hommey [:glandium]]

Backed out with bug 717540.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e652994cdd9e

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91d77c934b26

Comment 9

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/91d77c934b26