[TSF] Remove text event hack for the nsEditor's hack which will be removed by bug 622247

RESOLVED FIXED in mozilla13

Status

()

Core
Widget: Win32
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla13
x86_64
Windows 7
inputmethod
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

When nsTextStore needs to dispatch empty text event immediately after compositionstart, it dispatches two text events. One has a whitespace and the other has empty string.

If there is no composition string, nsEditor does nothing if empty text event comes. But of course, it should replace selected text with empty string. Therefore, nsTextEditor dispatches the hacky first event.

The nsEditor's behavior will be fixed by bug 622247. After that, we should remove the hacky event dispatchers.
Created attachment 597269 [details] [diff] [review]
Patch

I'm not sure how to test these cases actually, however, our internal code is tested by automated tests which will be landed by bug 622247. So, this patch must be safe.
Attachment #597269 - Flags: review?(jmathies)

Updated

6 years ago
Attachment #597269 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f444ebecc91f
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/f444ebecc91f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.