725247 - Turning the screen on doesn't repaint the screen

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Find a page that doesn't invalidate all the freaking time
 (2) Load it
 (3) Turn off the screen
 (4) Turn it back on

The screen stays blank because nothing ever asks gonk widgetry to repaint.

We need some sort of notification when the screen is turned off/on.  Adding an nsIScreen method to deal with enable/disable should work just fine.  the screen impl can call the gonk method to do the real business.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Bug 714416 isn't a functional requirement for this, but it contains a small refactoring that we need to use here.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

mwu want to grab this?

Comment 3

[Michael Wu [:mwu]]

Attachment: Redraw when screen turns on

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 598892 [details] [diff] [review]
Redraw when screen turns on

r=me for direct-to-b2g

Comment 5

[Michael Wu [:mwu]]

https://github.com/cgjones/mozilla-central/commit/6a16a82af7832aa6004b50ac242628a4923660a6

Comment 6

[Michael Wu [:mwu]]

cjones, how do you want to proceed with this? I don't have any ideas for how to investigate this further.

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We should send out a notification from hal when the screen goes on/off and have nsWindow listen to that.  The rest of the approach here is fine.

Comment 8

[Kan-Ru Chen [:kanru] (UTC+9)]

I want to implement bug 707589 which will also help this bug. The key is /sys/power/wait_for_fb_sleep and /sys/power/wait_for_fb_wake

Comment 9

[Michael Wu [:mwu]]

(In reply to Kan-Ru Chen [:kanru] from comment #8)
> I want to implement bug 707589 which will also help this bug. The key is
> /sys/power/wait_for_fb_sleep and /sys/power/wait_for_fb_wake

Hm interesting. wait_for_fb_wake may avoid the problem we have in this bug where we have to redraw twice to get things to show.

Comment 10

[Michael Wu [:mwu]]

Kanru has a better approach to this.

Comment 11

[Kan-Ru Chen [:kanru] (UTC+9)]

Fixed by bug 707589 as a side effect. Verified on akami and sgs2.