Turning the screen on doesn't repaint the screen

RESOLVED FIXED

Status

()

Core
Widget
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cjones, Assigned: kanru)

Tracking

Trunk
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

STR
 (1) Find a page that doesn't invalidate all the freaking time
 (2) Load it
 (3) Turn off the screen
 (4) Turn it back on

The screen stays blank because nothing ever asks gonk widgetry to repaint.

We need some sort of notification when the screen is turned off/on.  Adding an nsIScreen method to deal with enable/disable should work just fine.  the screen impl can call the gonk method to do the real business.
Bug 714416 isn't a functional requirement for this, but it contains a small refactoring that we need to use here.
Depends on: 714416
mwu want to grab this?

Comment 3

5 years ago
Created attachment 598892 [details] [diff] [review]
Redraw when screen turns on
Assignee: nobody → mwu
Attachment #598892 - Flags: review?(jones.chris.g)
Comment on attachment 598892 [details] [diff] [review]
Redraw when screen turns on

r=me for direct-to-b2g
Attachment #598892 - Flags: review?(jones.chris.g) → review+

Comment 5

5 years ago
https://github.com/cgjones/mozilla-central/commit/6a16a82af7832aa6004b50ac242628a4923660a6

Comment 6

5 years ago
cjones, how do you want to proceed with this? I don't have any ideas for how to investigate this further.
We should send out a notification from hal when the screen goes on/off and have nsWindow listen to that.  The rest of the approach here is fine.
(Assignee)

Comment 8

5 years ago
I want to implement bug 707589 which will also help this bug. The key is /sys/power/wait_for_fb_sleep and /sys/power/wait_for_fb_wake
Depends on: 707589

Comment 9

5 years ago
(In reply to Kan-Ru Chen [:kanru] from comment #8)
> I want to implement bug 707589 which will also help this bug. The key is
> /sys/power/wait_for_fb_sleep and /sys/power/wait_for_fb_wake

Hm interesting. wait_for_fb_wake may avoid the problem we have in this bug where we have to redraw twice to get things to show.

Comment 10

5 years ago
Kanru has a better approach to this.
Assignee: mwu → kchen
(Assignee)

Comment 11

5 years ago
Fixed by bug 707589 as a side effect. Verified on akami and sgs2.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.