[Page Thumbnails] Reduce API provided by PageThumbs.jsm

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
From bug 720838 comment #12:

> I agree that adding a captureAndStore(aBrowser) method on PageThumbs would
> be useful, to reduce unnecessary complexity for the primary use of this API
> (browser-thumbnails.js).
> 
> Exposing store() as part of the PageThumbs API doesn't seem justified at the
> moment. Who would want to use an arbitrary key or save data from another
> source? This could actually lead to trouble if addons end up improperly
> storing data. I can see capture()'s potentially utility, though, and keeping
> it doesn't seem harmful.
(Assignee)

Comment 1

5 years ago
Created attachment 595382 [details] [diff] [review]
patch v1

Implements the proposed API.

1) capture() remains untouched.
2) captureAndStore(aBrowser[, aCallback]) was added
3) store() got removed
Attachment #595382 - Flags: review?(dietrich)
Comment on attachment 595382 [details] [diff] [review]
patch v1

Review of attachment 595382 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/thumbnails/PageThumbs.jsm
@@ +110,3 @@
>     */
> +  captureAndStore: function PageThumbs_captureAndStore(aBrowser, aCallback) {
> +    this.capture(aBrowser.contentWindow, function (aData) {

aData too ambiguous, rename to reflect actual type.
Attachment #595382 - Flags: review?(dietrich) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/bcd726a4a258
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
(Assignee)

Comment 4

5 years ago
Backed out because I accidentally slipped in changes from another patch:

https://hg.mozilla.org/integration/fx-team/rev/363923689d48

Pushed again:

https://hg.mozilla.org/integration/fx-team/rev/113832a73df9
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/bcd726a4a258
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/363923689d48
https://hg.mozilla.org/mozilla-central/rev/113832a73df9
You need to log in before you can comment on or make changes to this bug.