725292 - some repacks failed in 11.0b2 because of missing tokens

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[[e-mail] (:bhearsum)]

The errors found in the log were:
python /e/builds/moz2_slave/rel-m-beta-w32-rpk-2/scripts/release/signing/signtool.py --cachedir /e/builds/moz2_slave/rel-m-beta-w32-rpk-2/signing_cache -t /e/builds/moz2_slave/rel-m-beta-w32-rpk-2/build/token -n /e/builds/moz2_slave/rel-m-beta-w32-rpk-2/build/nonce -c /e/builds/moz2_slave/rel-m-beta-w32-rpk-2/scripts/release/signing/host.cert -H signing1.build.scl1.mozilla.com:9020 -H signing2.build.scl1.mozilla.com:9020 -f signcode -f gpg "l10ngen/setup.exe"
Traceback (most recent call last):
  File "e:/builds/moz2_slave/rel-m-beta-w32-rpk-2/scripts/release/signing/signtool.py", line 170, in <module>
    main()
  File "e:/builds/moz2_slave/rel-m-beta-w32-rpk-2/scripts/release/signing/signtool.py", line 142, in main
    token = open(options.tokenfile, 'rb').read()
IOError: [Errno 2] No such file or directory: 'e:/builds/moz2_slave/rel-m-beta-w32-rpk-2/build/token'

I couldn't find any related errors in the master's twistd.log nor on the signing server. I inspected a slave by hand and there was no '/e/builds/moz2_slave/rel-m-beta-w32-rpk-2/build' directory at all.

Comment 1

[Chris AtLee [:catlee]]

Looks like the token got downloaded, and then clobbered as part of the repack script.

Comment 2

[Chris AtLee [:catlee]]

rel-m-beta-w32-rpk-2:Our last clobber date:  2012-02-07 14:17:18
rel-m-beta-w32-rpk-2:Server clobber date:    2012-02-08 02:54:35
rel-m-beta-w32-rpk-2:Server is forcing a clobber, initiated by [e-mail]
rel-m-beta-w32-rpk-2:Clobbering...
Removing build/
Skipping buildprops.json
Skipping last-clobber
Skipping scripts

Comment 3

[Rail Aliiev [:rail]]

should we just add "-s build/token -s build/nonce" as extra params to clobber.py?

Comment 4

[Chris AtLee [:catlee]]

I think build/ would still get deleted...maybe we should move token and nonce to build/../

Comment 5

[Rail Aliiev [:rail]]

Attachment: move token/nonce 1 level up

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 597017 [details] [diff] [review]
move token/nonce 1 level up

Review of attachment 597017 [details] [diff] [review]:
-----------------------------------------------------------------

Yay

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 597017 [details] [diff] [review]
move token/nonce 1 level up

http://hg.mozilla.org/build/buildbotcustom/rev/7fea4233c693

Comment 8

[Rail Aliiev [:rail]]

Attachment: don't clobber important files

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 597422 [details] [diff] [review]
don't clobber important files

http://hg.mozilla.org/build/tools/rev/34d449ecf0c0

Comment 10

[Rail Aliiev [:rail]]

Seen in 11.0b3:
Skipping token