725323 - New loader introduced regressions with thunderbird support

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Currently, developers can't play with jetpack on thunderbird at all.
Because main module won't even be loaded because of some silent errors in the loader code on thunderbird, on windows! (It seems to work on Mac)
So even if they patch manually the install.rdf file, it can't work.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Pull request 340

I mentioned these issues during our last weekly meeting,
so we need to do simple fixes around hiddenWindow usage in order to enable addons to work again on thunderbird/windows.

The next step will be to ease modification of install.rdf in order to be able to use cfx run/xpi directly on thunderbird. See bug 724276.

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Comment on attachment 595413 [details]
Pull request 340

I don't remember if you verified this fix.
Can you confirm that it fixes thunderbird support for you addon?
I'll like to get this confirmation before landing this patch.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Comment on attachment 595413 [details]
Pull request 340

Well, the widget module still doesn't support Thunderbird. So I can't really verify it. 

Error: Error: The widget module currently supports only Firefox.  In the future it will support other applications. Please see https://bugzilla.mozilla.org/show_bug.cgi?id=560716 for more information.
Source File: resource://memchaser-at-quality-dot-mozilla-dot-org/api-utils/lib/cuddlefish.js
Line: 268

Would it make sense to make a distinction between the addon bar and status bar depending on the application? Or wouldn't you want to hard-code it for now?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Comment on attachment 595413 [details]
Pull request 340

Meant to reset the feedback flag.

Comment 5

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Oh Widget support is really another subject. Here I'm only trying to enable running an empty addon on thunderbird. It will allows to use modules that are already compatible with all mozilla applications.
Adding thunderbird support for the widget API may not be that easy.

We are currently discussing with Thunderbird team in order to find someone that will ensure that SDK doesn't break thunderbird support. We do not want to promise/enable thunderbird support without ensuring that it works over releases. And as jetpack team is really small, we can't assigned this to ourself.

So my best suggestiong would be to open a new bug for widget support.
The purpose of this one being to just enable running addons.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

So not sure what I should check. The entry in install.rdf I have to add manually and installing my extension in Thunderbird doesn't show a difference. What exactly should I see? Any error in the error console without the patch applied? I don't. So steps to test would be helpful.

Comment 7

[Alexandre Poirot [:ochameau] [PTO back August 21]]

1. edit install.rdf in order to add thunderbird targetApplication
2. cfx run
3. see if modules already compatible with thunderbird works, like your garbage collector module, or simply the console API.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

In case of not having the patch applied, what should I see instead?

Comment 9

[Alexandre Poirot [:ochameau] [PTO back August 21]]

I don't remember if there was exception being thrown.
But the final effect is that your main module is never evaluated.
So if it's not applied you shouldn't see anything from your main module being executed.

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/cbf4018bdeac56a79eafff3520d5023d8b00b63c
Merge pull request #340 from ochameau/thunderbird-fixes

fix Bug 725323 - Fix hiddenWindow issues on Thunderbird/Windows. r=@gozala

Comment 11

[[github robot]]

Commit pushed to release at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/cbf4018bdeac56a79eafff3520d5023d8b00b63c
Merge pull request #340 from ochameau/thunderbird-fixes