The default bug view has changed. See this FAQ.

IonMonkey: Don't call TypeScript::Monitor from the GetElement stub

RESOLVED FIXED in mozilla13

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

unspecified
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Leave open after merge])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 595418 [details] [diff] [review]
Patch

I think you suggested this a while ago and this is a nice speedup, also because getting the script and pc is more expensive for Ion frames.
Attachment #595418 - Flags: review?(bhackett1024)
(Assignee)

Comment 1

5 years ago
Comment on attachment 595418 [details] [diff] [review]
Patch

Brian says we need to emit code after the GetElement call to handle the monitoring, since barriers don't handle this. I somehow missed the code for this in JM (testPushedType)..
Attachment #595418 - Flags: review?(bhackett1024)
(Assignee)

Comment 2

5 years ago
Created attachment 595503 [details] [diff] [review]
Patch
Attachment #595418 - Attachment is obsolete: true
Attachment #595503 - Flags: review?(dvander)
(Assignee)

Updated

5 years ago
Duplicate of this bug: 728187
(Assignee)

Comment 4

5 years ago
Created attachment 598566 [details] [diff] [review]
Patch

A bit cleaner than the previous patch and now also checks the result of the GETPROP/NAME VM calls (fixes bug 728187 and tons of inference failures caught by the fuzzers).

I can land the jsinterp* changes on inbound first.
Attachment #595503 - Attachment is obsolete: true
Attachment #595503 - Flags: review?(dvander)
Attachment #598566 - Flags: review?(dvander)
Duplicate of this bug: 728045
Attachment #598566 - Flags: review?(dvander) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b712e681cc8c

Please don't close this bug when merging to m-c.
Whiteboard: [Leave open after merge]
https://hg.mozilla.org/mozilla-central/rev/b712e681cc8c
Target Milestone: --- → mozilla13
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/eef8527f7ef1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Duplicate of this bug: 729789
(Assignee)

Updated

5 years ago
Duplicate of this bug: 729802
You need to log in before you can comment on or make changes to this bug.