Closed
Bug 725357
Opened 14 years ago
Closed 14 years ago
IonMonkey: Don't call TypeScript::Monitor from the GetElement stub
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Leave open after merge])
Attachments
(1 file, 2 obsolete files)
|
22.49 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
I think you suggested this a while ago and this is a nice speedup, also because getting the script and pc is more expensive for Ion frames.
Attachment #595418 -
Flags: review?(bhackett1024)
|
Assignee | |
Comment 1•14 years ago
|
||
Comment on attachment 595418 [details] [diff] [review]
Patch
Brian says we need to emit code after the GetElement call to handle the monitoring, since barriers don't handle this. I somehow missed the code for this in JM (testPushedType)..
Attachment #595418 -
Flags: review?(bhackett1024)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #595418 -
Attachment is obsolete: true
Attachment #595503 -
Flags: review?(dvander)
|
|
Assignee | |
Comment 4•14 years ago
|
||
A bit cleaner than the previous patch and now also checks the result of the GETPROP/NAME VM calls (fixes bug 728187 and tons of inference failures caught by the fuzzers).
I can land the jsinterp* changes on inbound first.
Attachment #595503 -
Attachment is obsolete: true
Attachment #595503 -
Flags: review?(dvander)
Attachment #598566 -
Flags: review?(dvander)
|
||
Updated•14 years ago
|
Attachment #598566 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b712e681cc8c
Please don't close this bug when merging to m-c.
Whiteboard: [Leave open after merge]
|
|
||
Comment 7•14 years ago
|
||
Target Milestone: --- → mozilla13
|
|
Assignee | |
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•