725513 - Enable logging of sensitive information in Nightly

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Android Sync, defect, P4)

Description

[Richard Newman [:rnewman]]

That'll do for now, until we can address Bug 725030 and Bug 725082.

(And of course, make sure that everything we don't want to log is a trace item!)

Comment 1

[David Chan [:dchan]]

I did some testing with the following code

System.setProperty("log.tag." + TAG, "" + Log.ERROR);
Log.v(TAG, "testing verbose");
Log.e(TAG, "testing error");


The call to Log.v() still logs even though the log is set to only log for ERROR and above. If I wrap the Log.v() call with
if (Log.isLoggable(TAG, Log.VERBOSE)) {
  Log.v(TAG, "testing verbose");
}

then nothing is logged...

Comment 2

[Richard Newman [:rnewman]]

Yeah, I've got a utility method to do these checks.

Comment 3

[Richard Newman [:rnewman]]

Let's flip this around after Bug 725525. Trace logging is off by default, but controlled by the VERBOSE system setting.

The logging of sensitive information is hard-coded to off.

Comment 4

[Tracy Walker [:tracy]]

what is considered sensitive here?

Comment 5

[Richard Newman [:rnewman]]

(In reply to Tracy Walker [:tracy] from comment #4)
> what is considered sensitive here?

Anything logged by Logger.pii().

Comment 6

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Are we still interested in this?  I'm pretty sure we *never* want to log PII without developer intervention.