Closed Bug 725535 Opened 8 years ago Closed 8 years ago

"ASSERTION: Only transformed frames should have UpdateTransformLayer hint"

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: jruderman, Assigned: mats)

References

(Blocks 2 open bugs)

Details

(Keywords: assertion, regression, testcase)

Attachments

(4 files)

Attached file testcase
###!!! ASSERTION: Only transformed frames should have UpdateTransformLayer hint: '!(aChange & nsChangeHint_UpdateTransformLayer) || aFrame->IsTransformed()', file layout/base/nsCSSFrameConstructor.cpp, line 7678

This assertion was added in mozilla-central rev 6784eefe33a6 (bug 722923).
Attached file stack trace
Attached file the frames involved
Attached patch fix+testSplinter Review
The assert needs to be first in ApplyRenderingChangeToTree() because it
sometimes "adjusts" aFrame to an ancestor:

  // If the frame's background is propagated to an ancestor, walk up to
  // that ancestor.
  nsStyleContext *bgSC;
  while (!nsCSSRendering::FindBackground(aPresContext, aFrame, &bgSC)) {
    aFrame = aFrame->GetParent();
    NS_ASSERTION(aFrame, "root frame must paint");
  }
Assignee: nobody → matspal
Attachment #595777 - Flags: review?(roc)
https://hg.mozilla.org/integration/mozilla-inbound/rev/df43cc1f72e1
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86_64 → All
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/0c1fdf386ac1 since I wasn't sure which reftest failures and which crashtest assertion count failures went with which cset in the push.
Whiteboard: [inbound]
Target Milestone: mozilla13 → ---
https://hg.mozilla.org/integration/mozilla-inbound/rev/76cf2be70d90
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/76cf2be70d90
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.