"ASSERTION: Only transformed frames should have UpdateTransformLayer hint"

RESOLVED FIXED in mozilla13

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: mats)

Tracking

(Blocks: 2 bugs, {assertion, regression, testcase})

Trunk
mozilla13
assertion, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

5 years ago
Created attachment 595584 [details]
testcase

###!!! ASSERTION: Only transformed frames should have UpdateTransformLayer hint: '!(aChange & nsChangeHint_UpdateTransformLayer) || aFrame->IsTransformed()', file layout/base/nsCSSFrameConstructor.cpp, line 7678

This assertion was added in mozilla-central rev 6784eefe33a6 (bug 722923).
(Reporter)

Comment 1

5 years ago
Created attachment 595585 [details]
stack trace
(Assignee)

Comment 2

5 years ago
Created attachment 595776 [details]
the frames involved
(Assignee)

Comment 3

5 years ago
Created attachment 595777 [details] [diff] [review]
fix+test

The assert needs to be first in ApplyRenderingChangeToTree() because it
sometimes "adjusts" aFrame to an ancestor:

  // If the frame's background is propagated to an ancestor, walk up to
  // that ancestor.
  nsStyleContext *bgSC;
  while (!nsCSSRendering::FindBackground(aPresContext, aFrame, &bgSC)) {
    aFrame = aFrame->GetParent();
    NS_ASSERTION(aFrame, "root frame must paint");
  }
Assignee: nobody → matspal
Attachment #595777 - Flags: review?(roc)
Attachment #595777 - Flags: review?(roc) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/df43cc1f72e1
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86_64 → All
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/0c1fdf386ac1 since I wasn't sure which reftest failures and which crashtest assertion count failures went with which cset in the push.
Whiteboard: [inbound]
Target Milestone: mozilla13 → ---
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/76cf2be70d90
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/76cf2be70d90
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.