725581 - caretOffset for textarea should be -1 when textarea doesn't have a focus

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

when document is focused but textarea is not then caretOffset on textarea returns the focus position of selection.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

new portions of ifs unfortunately

Comment 2

[alexander :surkov (:asurkov)]

note, the patch enables tests disabled in bug 510128

Comment 3

[alexander :surkov (:asurkov)]

(In reply to alexander :surkov from comment #2)
> note, the patch enables tests disabled in bug 510128

and I think this bug is a fix for bug 510128

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 595669 [details] [diff] [review]
patch

Nice to get rid of that todo!

Comment 5

[alexander :surkov (:asurkov)]

some details:
Since elements like input or textarea has own selection controller then selection we get is different from documents one. Since selection is turned into caret position then we can get result different from -1 for these controls if document is focused (see eContainedByFocus check in nsHyperTextAccessible::GetCaretOffset).

Comment 6

[Trevor Saunders (:tbsaunde)]

Comment on attachment 595669 [details] [diff] [review]
patch

its kind of weird but I think this makes sense.  We should look at ways to make the check if we're focusable faster.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/c646a6e4dd2e