725599 - B2G telephony: speakerEnabled does not work

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Maria Angeles Oteo (:oteo)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_2) AppleWebKit/534.51.22 (KHTML, like Gecko) Version/5.1.1 Safari/534.51.22

Steps to reproduce:

Trying to activate/deactivate the speaker in Samsung Galaxy SII 


Actual results:

Setting the attribute navigator.mozTelephony.speakerEnabled either to true or false we get the following errors in the log:

E/GeckoConsole( 6203): [JavaScript Error: "uncaught exception:
[Exception... "'[JavaScript Error: "gAudioManager.setForceUse is not a
function" {file:
"jar:file:///system/b2g/omni.ja!/components/RadioInterfaceLayer.js" line:
419}]' when calling method: [nsIRadioInterfaceLayer::speakerEnabled]"
nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"
location: "JS frame :: http://localhost:6666/Telephony/script/dialer.js ::
<TOP_LEVEL> :: line 579"  data: yes]"]
E/GeckoConsole( 6203): [JavaScript Error: "uncaught exception:
[Exception... "'[JavaScript Error: "gAudioManager.setForceUse is not a
function" {file:
"jar:file:///system/b2g/omni.ja!/components/RadioInterfaceLayer.js" line:
419}]' when calling method: [nsIRadioInterfaceLayer::speakerEnabled]"
nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"
location: "JS frame :: http://localhost:6666/Telephony/script/dialer.js ::
<TOP_LEVEL> :: line 579"  data: yes]"]
E/GeckoConsole( 6203): [JavaScript Error: "uncaught exception:
[Exception... "'[JavaScript Error: "gAudioManager.setForceUse is not a
function" {file:
"jar:file:///system/b2g/omni.ja!/components/RadioInterfaceLayer.js" line:
419}]' when calling method: [nsIRadioInterfaceLayer::speakerEnabled]"
nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"
location: "JS frame :: http://localhost:6666/Telephony/script/dialer.js ::
<TOP_LEVEL> :: line 579"  data: yes]"]

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v1

This patch fix an small problem ("gAudioManager.setForceUse is not a function") when enabling speakers on a call.

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 595992 [details] [diff] [review]
v1

Review of attachment 595992 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch! r=me

Comment 4

[Philipp von Weitershausen [:philikon]]

(Please file telephony bugs in the Core :: DOM: Device Interfaces section next time, and mark them blocking the b2g-telephony meta bug. Both of those will ensure that the right kind of people are notified via email. Thanks! :))

Comment 5

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/40da5acfe838