Last Comment Bug 725605 - IonMonkey: CallGetProperty should accept both objects and strings
: IonMonkey: CallGetProperty should accept both objects and strings
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To: Jan de Mooij [:jandem]
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: IonSpeed
  Show dependency treegraph
Reported: 2012-02-09 03:03 PST by Jan de Mooij [:jandem]
Modified: 2012-02-16 05:21 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (9.46 KB, patch)
2012-02-09 03:03 PST, Jan de Mooij [:jandem]
dvander: review+
Details | Diff | Splinter Review

Description User image Jan de Mooij [:jandem] 2012-02-09 03:03:12 PST
Created attachment 595694 [details] [diff] [review]

date-format-xparb has this function:
var result = new String(val);
// ...
while (result.length < size) {
    result = ch + result;
result.length bails out because result is a string after the first iteration and is unboxed as object. The patch changes CallGetProperty to accept a Value so that we can handle both objects and strings without bailing out.

The patch may regress some other tests a bit, but I think this is the right way forward and we can use IC's or fast paths to fix these regressions.
Comment 1 User image Jan de Mooij [:jandem] 2012-02-16 05:21:49 PST

Note You need to log in before you can comment on or make changes to this bug.