Keyboard arrow keys and scrollbar buttons should have consistent scrolling distances

VERIFIED FIXED in mozilla13

Status

()

Core
General
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

(Blocks: 1 bug)

Trunk
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Snappy:P1][fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

Bug 635645 made keyboard arrow keys scroll two lines at a time. Bug 710373 made the scrollbar buttons scroll three lines at a time.

These scrolling distances should be consistent, and we should make the arrow keys scroll three lines at a time instead of two.

To make sure that these distances stay consistent going forward, these distances should use a shared preferences (possibly updated through about:config).

Updated

5 years ago
Whiteboard: [Snappy:P1]
Assignee: nobody → jwein
Status: NEW → ASSIGNED
Created attachment 597236 [details] [diff] [review]
Patch for bug
Attachment #597236 - Flags: review?(smontagu)
Blocks: 710372
Attachment #597236 - Flags: review?(smontagu) → review+
Whiteboard: [Snappy:P1] → [Snappy:P1][autoland-try]

Updated

5 years ago
Whiteboard: [Snappy:P1][autoland-try] → [Snappy:P1][autoland-in-queue]

Comment 2

5 years ago
Autoland Patchset:
	Patches: 597236
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=6c47f76858c8
Try run started, revision 6c47f76858c8. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=6c47f76858c8
Created attachment 597601 [details] [diff] [review]
Patch for bug v2

The push to try showed that docshell/test/navigation/test_bug430723.html was broken since the test reached the bottom of the window before the scroll iterations were finished and the scroll event wouldn't fire anymore on DOWN key.

I've updated the test to scroll down less since the distance of scrolling has been increased.
Attachment #597236 - Attachment is obsolete: true
Attachment #597601 - Flags: review?(smontagu)

Comment 4

5 years ago
Try run for 6c47f76858c8 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6c47f76858c8
Results (out of 212 total builds):
    success: 168
    warnings: 30
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-6c47f76858c8

Updated

5 years ago
Whiteboard: [Snappy:P1][autoland-in-queue] → [Snappy:P1]
Whiteboard: [Snappy:P1] → [Snappy:P1][autoland-try]

Updated

5 years ago
Whiteboard: [Snappy:P1][autoland-try] → [Snappy:P1][autoland-in-queue]

Comment 5

5 years ago
Autoland Patchset:
	Patches: 597601
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=c6f9bd404ae0
Try run started, revision c6f9bd404ae0. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=c6f9bd404ae0

Comment 6

5 years ago
Try run for c6f9bd404ae0 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c6f9bd404ae0
Results (out of 209 total builds):
    success: 145
    warnings: 13
    failure: 51
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-c6f9bd404ae0

Updated

5 years ago
Whiteboard: [Snappy:P1][autoland-in-queue] → [Snappy:P1]
review ping? only change from previous r+'d version is the test update.
Attachment #597601 - Flags: review?(smontagu) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/74cb4c127dc1
Keywords: checkin-needed
Whiteboard: [Snappy:P1] → [Snappy:P1][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/74cb4c127dc1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20100101 Firefox/13.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20100101 Firefox/13.0

Verified that both keyboard arrows and scrollbar buttons scroll about 3 lines at once.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.