The default bug view has changed. See this FAQ.

Status

()

Core
JavaScript Engine
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Adam, Assigned: Adam)

Tracking

unspecified
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Following bug #688891, this replaces the old API calls with the newer ones.
(Assignee)

Comment 1

5 years ago
Created attachment 595835 [details] [diff] [review]
sprinter-cleanup.diff
Attachment #595835 - Flags: review?(jwalden+bmo)
Comment on attachment 595835 [details] [diff] [review]
sprinter-cleanup.diff

Review of attachment 595835 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, save for the one nit.  I'll fix it and push for you.  Thanks!

::: js/src/jsopcode.cpp
@@ +1611,3 @@
>                               ? "0 / 0"
>                               : (d < 0)
>                               ? "1 / -0"

Please re-indent the rest of this condition, since you're touching this.
Attachment #595835 - Flags: review?(jwalden+bmo) → review+
Bonus points if you add

template<size_t N>
ptrdiff_t put(const char (&s)[N])
{
  return put(s, N - 1);
}

and remove the explicit put(literal string, length of the literal string) calls. (Followup is fine, of course.)
And thanks for doing this!
Assignee: general → adam
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
https://hg.mozilla.org/mozilla-central/rev/ad596e4e1c79
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.