725765 - Sprinter cleanup

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Adam]

Following bug #688891, this replaces the old API calls with the newer ones.

Comment 1

[Adam]

Attachment: sprinter-cleanup.diff

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 595835 [details] [diff] [review]
sprinter-cleanup.diff

Review of attachment 595835 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, save for the one nit.  I'll fix it and push for you.  Thanks!

::: js/src/jsopcode.cpp
@@ +1611,3 @@
>                               ? "0 / 0"
>                               : (d < 0)
>                               ? "1 / -0"

Please re-indent the rest of this condition, since you're touching this.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Bonus points if you add

template<size_t N>
ptrdiff_t put(const char (&s)[N])
{
  return put(s, N - 1);
}

and remove the explicit put(literal string, length of the literal string) calls. (Followup is fine, of course.)

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

And thanks for doing this!

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/ad596e4e1c79