Closed
Bug 725765
Opened 13 years ago
Closed 13 years ago
Sprinter cleanup
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: adam, Assigned: adam)
Details
Attachments
(1 file)
|
20.58 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Following bug #688891, this replaces the old API calls with the newer ones.
Attachment #595835 -
Flags: review?(jwalden+bmo)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 595835 [details] [diff] [review]
sprinter-cleanup.diff
Review of attachment 595835 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, save for the one nit. I'll fix it and push for you. Thanks!
::: js/src/jsopcode.cpp
@@ +1611,3 @@
> ? "0 / 0"
> : (d < 0)
> ? "1 / -0"
Please re-indent the rest of this condition, since you're touching this.
Attachment #595835 -
Flags: review?(jwalden+bmo) → review+
|
||
Comment 3•13 years ago
|
||
Bonus points if you add
template<size_t N>
ptrdiff_t put(const char (&s)[N])
{
return put(s, N - 1);
}
and remove the explicit put(literal string, length of the literal string) calls. (Followup is fine, of course.)
|
|
||
Comment 4•13 years ago
|
||
And thanks for doing this!
Assignee: general → adam
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•