Closed Bug 725787 Opened 8 years ago Closed 8 years ago

Robotium: loadUrl should be callable more than one time

Categories

(Firefox for Android :: General, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 13

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
loadUrl calls enterUrl which blocks while waiting for Gecko:Ready. This might have been handy for those tests that only call loadUrl and do a simple test, but it's not helpful for tests that load more than one page.

This patch pulls the Gecko:Ready wait out of enterUrl and adds it to the top of tests that seem to need it.
Attachment #595857 - Flags: review?(gbrown)
Sending to Try to make sure I got all the tests
Comment on attachment 595857 [details] [diff] [review]
patch

Review of attachment 595857 [details] [diff] [review]:
-----------------------------------------------------------------

You missed test_bug720538!

r+ with one more Gecko:Ready wait in test_bug720538.
Attachment #595857 - Flags: review?(gbrown) → review+
Would it work if we throw this in BaseTest.setUp() instead of duplicating it everywhere?
(In reply to Kartikaya Gupta (:kats) from comment #3)
> Would it work if we throw this in BaseTest.setUp() instead of duplicating it
> everywhere?

I prefer it the way Mark has done it: I like to see that step explicitly when I'm reading the test code. Also, it makes it easier to write a test that doesn't wait for Gecko:Ready.
https://hg.mozilla.org/mozilla-central/rev/7422761d5b90
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.