725787 - Robotium: loadUrl should be callable more than one time

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

loadUrl calls enterUrl which blocks while waiting for Gecko:Ready. This might have been handy for those tests that only call loadUrl and do a simple test, but it's not helpful for tests that load more than one page.

This patch pulls the Gecko:Ready wait out of enterUrl and adds it to the top of tests that seem to need it.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Sending to Try to make sure I got all the tests

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 595857 [details] [diff] [review]
patch

Review of attachment 595857 [details] [diff] [review]:
-----------------------------------------------------------------

You missed test_bug720538!

r+ with one more Gecko:Ready wait in test_bug720538.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Would it work if we throw this in BaseTest.setUp() instead of duplicating it everywhere?

Comment 4

[Geoff Brown [:gbrown]]

(In reply to Kartikaya Gupta (:kats) from comment #3)
> Would it work if we throw this in BaseTest.setUp() instead of duplicating it
> everywhere?

I prefer it the way Mark has done it: I like to see that step explicitly when I'm reading the test code. Also, it makes it easier to write a test that doesn't wait for Gecko:Ready.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7422761d5b90

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7422761d5b90