725910 - Robotium: Add simple about: page tests

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Navigating to the about page (typing the URL and via the settings UI) has crashed in the past. This is a simple test to make sure we display the page.

I used regex to get around the ever-changing name of the app.

Comment 1

[Geoff Brown [:gbrown]]

Comment on attachment 595927 [details] [diff] [review]
patch

Review of attachment 595927 [details] [diff] [review]:
-----------------------------------------------------------------

I love the regexes!

This works fine on a tablet but fails on a phone because the Settings menu item is behind "More":

org.mozilla.fennec_mozdev.tests.testAboutPage:
Failure in testAboutPage:
junit.framework.AssertionFailedError: The text: ^Settings$ is not found!
	at com.jayway.android.robotium.solo.Clicker.clickOnText(Clicker.java:279)
	at com.jayway.android.robotium.solo.Solo.clickOnText(Solo.java:823)
	at org.mozilla.fennec_mozdev.tests.testAboutPage.testAboutPage(testAboutPage.java:27)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:204)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:194)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:520)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1449)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This patch adds a check for "More". Works on Gingerbread and Honeycomb. Sent to Try too.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa77c70cf4a7

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/fa77c70cf4a7