Closed
Bug 725925
Opened 13 years ago
Closed 13 years ago
ShadowableThebesLayer does useless extra composite into 1x1 fake surface
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: romaxa, Assigned: romaxa)
References
()
Details
Attachments
(1 file)
3.57 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
Puppet widget does extra rendering into 1x1 dummy surface which is causing extra composition and PixmanTransform calls and make css3d transform animation slower.
Attachment #595957 -
Flags: review?(jones.chris.g)
Comment on attachment 595957 [details] [diff] [review]
Quick fix for the extra dummy surface paint
I don't think we need the special case in BasicThebesLayer::PaintThebes. This fix is incomplete, but mattwoodrow's bug is the right way to go. Neither of these changes hurts anything.
Please add a note to that bug to revert these changes after it's ready.
Attachment #595957 -
Flags: review?(jones.chris.g) → review+
Comment 2•13 years ago
|
||
Landed as:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b43f4d9f38da
But backed out for reftest failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=b43f4d9f38da
https://hg.mozilla.org/integration/mozilla-inbound/rev/80910c61fba9
I think you want |!clipExtents.IsEmpty()|. And please test this ;).
Assignee | ||
Comment 4•13 years ago
|
||
Ok, ested new version on try and pushed again to inbound
Comment 5•13 years ago
|
||
Assignee: nobody → romaxa
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•