The default bug view has changed. See this FAQ.

ShadowableThebesLayer does useless extra composite into 1x1 fake surface

RESOLVED FIXED in mozilla13

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla13
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 595957 [details] [diff] [review]
Quick fix for the extra dummy surface paint

Puppet widget does extra rendering into 1x1 dummy surface which is causing extra composition and PixmanTransform calls and make css3d transform animation slower.
Attachment #595957 - Flags: review?(jones.chris.g)
Comment on attachment 595957 [details] [diff] [review]
Quick fix for the extra dummy surface paint

I don't think we need the special case in BasicThebesLayer::PaintThebes.  This fix is incomplete, but mattwoodrow's bug is the right way to go.  Neither of these changes hurts anything.

Please add a note to that bug to revert these changes after it's ready.
Attachment #595957 - Flags: review?(jones.chris.g) → review+
Landed as:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b43f4d9f38da

But backed out for reftest failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=b43f4d9f38da

https://hg.mozilla.org/integration/mozilla-inbound/rev/80910c61fba9
I think you want |!clipExtents.IsEmpty()|.  And please test this ;).
(Assignee)

Comment 4

5 years ago
Ok, ested new version on try and pushed again to inbound
https://hg.mozilla.org/mozilla-central/rev/f3f01935174c
Assignee: nobody → romaxa
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
(Assignee)

Updated

5 years ago
Depends on: 757380
You need to log in before you can comment on or make changes to this bug.