Closed Bug 725925 Opened 9 years ago Closed 9 years ago

ShadowableThebesLayer does useless extra composite into 1x1 fake surface

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: romaxa, Assigned: romaxa)

References

()

Details

Attachments

(1 file)

Puppet widget does extra rendering into 1x1 dummy surface which is causing extra composition and PixmanTransform calls and make css3d transform animation slower.
Attachment #595957 - Flags: review?(jones.chris.g)
Comment on attachment 595957 [details] [diff] [review]
Quick fix for the extra dummy surface paint

I don't think we need the special case in BasicThebesLayer::PaintThebes.  This fix is incomplete, but mattwoodrow's bug is the right way to go.  Neither of these changes hurts anything.

Please add a note to that bug to revert these changes after it's ready.
Attachment #595957 - Flags: review?(jones.chris.g) → review+
I think you want |!clipExtents.IsEmpty()|.  And please test this ;).
Ok, ested new version on try and pushed again to inbound
https://hg.mozilla.org/mozilla-central/rev/f3f01935174c
Assignee: nobody → romaxa
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Depends on: 757380
You need to log in before you can comment on or make changes to this bug.