Open
Bug 725948
Opened 13 years ago
Updated 2 years ago
mochitest-browser-chrome: stop special-casing StopIteration exception in browser-test.js
Categories
(Testing :: Mochitest, defect, P4)
Testing
Mochitest
Tracking
(Not tracked)
NEW
mozilla13
People
(Reporter: sgautherie, Unassigned)
References
(Blocks 1 open bug, )
Details
Attachments
(3 files)
1.06 KB,
patch
|
rcampbell
:
review-
|
Details | Diff | Splinter Review |
1.00 KB,
patch
|
Details | Diff | Splinter Review | |
1.66 KB,
patch
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/?tree=Try&rev=a872216b6fef
*mochitest-browser-chrome: no exception.
*mochitest-plain-5: 2 expected exceptions.
Flags: in-testsuite-
Reporter | ||
Comment 1•13 years ago
|
||
Attachment #596004 -
Flags: review?(rcampbell)
Reporter | ||
Comment 2•13 years ago
|
||
Better document bug 366936.
NB:
{
766 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_html5_tree_construction.html | nextTest() catched a StopIteration exception - [object StopIteration]
1510 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_html5_tree_construction_part2.html | nextTest() catched a StopIteration exception - [object StopIteration]
}
Relying on StopIteration (for these 2 tests) seems odd to me, but I won't mind more than that.
Attachment #596005 -
Flags: review?(sayrer)
Reporter | ||
Comment 3•13 years ago
|
||
http://mxr.mozilla.org/comm-central/source/mailnews/test/resources/asyncTestUtils.js
149 // the real driver!
150 function _async_driver() {
...
159 catch (ex) {
160 if (ex != StopIteration && ex != asyncExpectedEarlyAbort) {
Andrew, you may wish to check whether (silently) ignoring StopIteration is still needed/wanted.
May want to document/report/fix...
Reporter | ||
Comment 4•13 years ago
|
||
Current copy+paste'd code logs
{
TEST-UNEXPECTED-FAIL | ../../../resources/asyncTestUtils.js | Generator explosion. ex: [undefined undefined] async stack [undefined undefined] - See following stack:
}
but that was good enough for this run.
***
(In reply to Serge Gautherie (:sgautherie) from comment #3)
> Andrew, you may wish to check whether (silently) ignoring StopIteration is
> still needed/wanted.
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=6ab411ccb17d
*xpcshell: 60+ exceptions
*mozmill virtualenv: (Unrelated, Don't care.)
> May want to document/report/fix...
Are these xpcshell exceptions actually by design or should a bug be filed to improve/fix them?
Attachment #596105 -
Flags: feedback?(bugmail)
Comment 5•13 years ago
|
||
why do we need this?
Also, I'm not sure sayrer's reviewing code anymore.
Reporter | ||
Comment 6•13 years ago
|
||
(In reply to Rob Campbell [:rc] (robcee) from comment #5)
> why do we need this?
It doesn't seem to be needed (anymore): why keep it?
> Also, I'm not sure sayrer's reviewing code anymore.
Feel free to take over that review or to suggest another reviewer.
Comment 7•13 years ago
|
||
Comment on attachment 596004 [details] [diff] [review]
(Av1) browser-test.js: Stop special-casing StopIteration exception
we don't need to change this.
Attachment #596004 -
Flags: review?(rcampbell) → review-
Comment 8•11 years ago
|
||
Comment on attachment 596105 [details] [diff] [review]
(Cv1-CC-WIP1) asyncTestUtils.js: check where we stand wrt StopIteration
I think the idea was that StopIteration is an expected outcome. I expect this code was just a speculative guard, however, since if I had a real reason to worry about it I would have put a comment in.
PS: I realize this is dramatically late feedback; at the time I had been hoping to find time to do a more thorough investigation, that never happened, etc. I think we're fine either way, but I no longer have review authority on anything comm-central anymore either.
Attachment #596105 -
Flags: feedback?(bugmail)
Assignee | ||
Updated•7 years ago
|
Component: BrowserTest → Mochitest
Updated•5 years ago
|
Attachment #596005 -
Flags: review?(sayrer)
Comment 9•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: bugzillamozillaorg_serge_20140323 → nobody
Status: ASSIGNED → NEW
Updated•2 years ago
|
Severity: minor → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•