mochitest-browser-chrome: stop special-casing StopIteration exception in browser-test.js

ASSIGNED
Assigned to

Status

defect
P4
minor
ASSIGNED
8 years ago
2 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Blocks 1 bug)

Trunk
mozilla13
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(3 attachments)

https://tbpl.mozilla.org/?tree=Try&rev=a872216b6fef
*mochitest-browser-chrome: no exception.
*mochitest-plain-5: 2 expected exceptions.
Flags: in-testsuite-
Better document bug 366936.

NB:
{
766 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_html5_tree_construction.html | nextTest() catched a StopIteration exception - [object StopIteration]
1510 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_html5_tree_construction_part2.html | nextTest() catched a StopIteration exception - [object StopIteration]
}
Relying on StopIteration (for these 2 tests) seems odd to me, but I won't mind more than that.
Attachment #596005 - Flags: review?(sayrer)
http://mxr.mozilla.org/comm-central/source/mailnews/test/resources/asyncTestUtils.js
149 // the real driver!
150 function _async_driver() {
...
159     catch (ex) {
160       if (ex != StopIteration && ex != asyncExpectedEarlyAbort) {

Andrew, you may wish to check whether (silently) ignoring StopIteration is still needed/wanted.
May want to document/report/fix...
Depends on: 482195, 366936
Current copy+paste'd code logs
{
TEST-UNEXPECTED-FAIL | ../../../resources/asyncTestUtils.js | Generator explosion. ex: [undefined undefined] async stack [undefined undefined] - See following stack:
}
but that was good enough for this run.

***

(In reply to Serge Gautherie (:sgautherie) from comment #3)

> Andrew, you may wish to check whether (silently) ignoring StopIteration is
> still needed/wanted.

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=6ab411ccb17d
*xpcshell: 60+ exceptions
*mozmill virtualenv: (Unrelated, Don't care.)

> May want to document/report/fix...

Are these xpcshell exceptions actually by design or should a bug be filed to improve/fix them?
Attachment #596105 - Flags: feedback?(bugmail)
why do we need this?

Also, I'm not sure sayrer's reviewing code anymore.
(In reply to Rob Campbell [:rc] (robcee) from comment #5)

> why do we need this?

It doesn't seem to be needed (anymore): why keep it?

> Also, I'm not sure sayrer's reviewing code anymore.

Feel free to take over that review or to suggest another reviewer.
Comment on attachment 596004 [details] [diff] [review]
(Av1) browser-test.js: Stop special-casing StopIteration exception

we don't need to change this.
Attachment #596004 - Flags: review?(rcampbell) → review-
Comment on attachment 596105 [details] [diff] [review]
(Cv1-CC-WIP1) asyncTestUtils.js: check where we stand wrt StopIteration

I think the idea was that StopIteration is an expected outcome.  I expect this code was just a speculative guard, however, since if I had a real reason to worry about it I would have put a comment in.

PS: I realize this is dramatically late feedback; at the time I had been hoping to find time to do a more thorough investigation, that never happened, etc.  I think we're fine either way, but I no longer have review authority on anything comm-central anymore either.
Attachment #596105 - Flags: feedback?(bugmail)
Component: BrowserTest → Mochitest
You need to log in before you can comment on or make changes to this bug.