Last Comment Bug 725998 - get rid nsAccessibilityService::GetAccessibleOrContainer and GetContainerAccessible
: get rid nsAccessibilityService::GetAccessibleOrContainer and GetContainerAcce...
Status: RESOLVED FIXED
[good first bug][mentor=surkov.alexan...
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla13
Assigned To: Jignesh Kakadiya [:jhk]
:
Mentors:
Depends on:
Blocks: cleana11y
  Show dependency treegraph
 
Reported: 2012-02-10 07:50 PST by alexander :surkov
Modified: 2012-02-13 08:42 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.21 KB, patch)
2012-02-10 08:32 PST, Jignesh Kakadiya [:jhk]
no flags Details | Diff | Splinter Review
Removed method implementations (5.78 KB, patch)
2012-02-10 09:03 PST, Jignesh Kakadiya [:jhk]
surkov.alexander: review+
Details | Diff | Splinter Review
Patch (5.78 KB, patch)
2012-02-10 09:36 PST, Jignesh Kakadiya [:jhk]
no flags Details | Diff | Splinter Review

Description alexander :surkov 2012-02-10 07:50:10 PST
replace things like
GetAccService()->GetContainerAccessible(node, document);

on
document->GetContainerAccesible(node);

same for GetAccessibleOrContainer
Comment 1 Jignesh Kakadiya [:jhk] 2012-02-10 08:32:09 PST
Created attachment 596058 [details] [diff] [review]
Patch
Comment 2 alexander :surkov 2012-02-10 08:41:42 PST
additionally you need to remove these methods from nsAccessibilityService
Comment 3 Jignesh Kakadiya [:jhk] 2012-02-10 09:03:24 PST
Created attachment 596062 [details] [diff] [review]
Removed method implementations
Comment 4 alexander :surkov 2012-02-10 09:23:24 PST
Comment on attachment 596062 [details] [diff] [review]
Removed method implementations

Review of attachment 596062 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/base/FocusManager.cpp
@@ +292,2 @@
>      // Check if still focused. Otherwise we can end up with storing the active
>      // item for control that isn't focused anymore.

move nsDocAccessible* document after comment

@@ +292,3 @@
>      // Check if still focused. Otherwise we can end up with storing the active
>      // item for control that isn't focused anymore.
> +    nsAccessible* DOMFocus =document->GetAccessibleOrContainer(FocusedDOMNode());

space after =
Comment 5 Jignesh Kakadiya [:jhk] 2012-02-10 09:36:20 PST
Created attachment 596073 [details] [diff] [review]
Patch
Comment 6 alexander :surkov 2012-02-11 18:53:26 PST
inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/777a20d9e7c9
Comment 7 Marco Bonardo [::mak] 2012-02-13 08:42:46 PST
https://hg.mozilla.org/mozilla-central/rev/777a20d9e7c9

Note You need to log in before you can comment on or make changes to this bug.