725998 - get rid nsAccessibilityService::GetAccessibleOrContainer and GetContainerAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

replace things like
GetAccService()->GetContainerAccessible(node, document);

on
document->GetContainerAccesible(node);

same for GetAccessibleOrContainer

Comment 1

[Jignesh Kakadiya [:jhk]]

Attachment: Patch

Comment 2

[alexander :surkov (:asurkov)]

additionally you need to remove these methods from nsAccessibilityService

Comment 3

[Jignesh Kakadiya [:jhk]]

Attachment: Removed method implementations

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 596062 [details] [diff] [review]
Removed method implementations

Review of attachment 596062 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/base/FocusManager.cpp
@@ +292,2 @@
>      // Check if still focused. Otherwise we can end up with storing the active
>      // item for control that isn't focused anymore.

move nsDocAccessible* document after comment

@@ +292,3 @@
>      // Check if still focused. Otherwise we can end up with storing the active
>      // item for control that isn't focused anymore.
> +    nsAccessible* DOMFocus =document->GetAccessibleOrContainer(FocusedDOMNode());

space after =

Comment 5

[Jignesh Kakadiya [:jhk]]

Attachment: Patch

Comment 6

[alexander :surkov (:asurkov)]

inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/777a20d9e7c9

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/777a20d9e7c9