Closed Bug 725998 Opened 8 years ago Closed 8 years ago

get rid nsAccessibilityService::GetAccessibleOrContainer and GetContainerAccessible

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: surkov, Assigned: jhk)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 file, 2 obsolete files)

replace things like
GetAccService()->GetContainerAccessible(node, document);

on
document->GetContainerAccesible(node);

same for GetAccessibleOrContainer
Attached patch Patch (obsolete) — Splinter Review
Attachment #596058 - Flags: review?(surkov.alexander)
additionally you need to remove these methods from nsAccessibilityService
Attachment #596058 - Flags: review?(surkov.alexander)
Attached patch Removed method implementations (obsolete) — Splinter Review
Attachment #596062 - Flags: review?(surkov.alexander)
Comment on attachment 596062 [details] [diff] [review]
Removed method implementations

Review of attachment 596062 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/base/FocusManager.cpp
@@ +292,2 @@
>      // Check if still focused. Otherwise we can end up with storing the active
>      // item for control that isn't focused anymore.

move nsDocAccessible* document after comment

@@ +292,3 @@
>      // Check if still focused. Otherwise we can end up with storing the active
>      // item for control that isn't focused anymore.
> +    nsAccessible* DOMFocus =document->GetAccessibleOrContainer(FocusedDOMNode());

space after =
Attachment #596062 - Flags: review?(surkov.alexander) → review+
Attached patch PatchSplinter Review
Attachment #596062 - Attachment is obsolete: true
Attachment #596058 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/777a20d9e7c9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.