The default bug view has changed. See this FAQ.

get rid nsAccessibilityService::GetAccessibleOrContainer and GetContainerAccessible

RESOLVED FIXED in mozilla13

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: jhk)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla13
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
replace things like
GetAccService()->GetContainerAccessible(node, document);

on
document->GetContainerAccesible(node);

same for GetAccessibleOrContainer
(Assignee)

Comment 1

5 years ago
Created attachment 596058 [details] [diff] [review]
Patch
Attachment #596058 - Flags: review?(surkov.alexander)
(Reporter)

Comment 2

5 years ago
additionally you need to remove these methods from nsAccessibilityService
(Reporter)

Updated

5 years ago
Attachment #596058 - Flags: review?(surkov.alexander)
(Assignee)

Comment 3

5 years ago
Created attachment 596062 [details] [diff] [review]
Removed method implementations
Attachment #596062 - Flags: review?(surkov.alexander)
(Reporter)

Comment 4

5 years ago
Comment on attachment 596062 [details] [diff] [review]
Removed method implementations

Review of attachment 596062 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/base/FocusManager.cpp
@@ +292,2 @@
>      // Check if still focused. Otherwise we can end up with storing the active
>      // item for control that isn't focused anymore.

move nsDocAccessible* document after comment

@@ +292,3 @@
>      // Check if still focused. Otherwise we can end up with storing the active
>      // item for control that isn't focused anymore.
> +    nsAccessible* DOMFocus =document->GetAccessibleOrContainer(FocusedDOMNode());

space after =
Attachment #596062 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 596073 [details] [diff] [review]
Patch
(Reporter)

Updated

5 years ago
Attachment #596062 - Attachment is obsolete: true
(Reporter)

Updated

5 years ago
Attachment #596058 - Attachment is obsolete: true
(Reporter)

Comment 6

5 years ago
inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/777a20d9e7c9
Assignee: nobody → jigneshhk1992
https://hg.mozilla.org/mozilla-central/rev/777a20d9e7c9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.