Closed
Bug 726005
Opened 12 years ago
Closed 12 years ago
IDRefsIterator::Next() should use nsDocAccessible::GetAccessible()
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: surkov, Assigned: jhk)
References
Details
(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])
Attachments
(1 file, 2 obsolete files)
10.70 KB,
patch
|
Details | Diff | Splinter Review |
For that IDRefsIterator constructor (http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/AccIterator.h#264) should take nsDocAccessible instance. Trevor, sounds good?
Comment 1•12 years ago
|
||
seems fine.
Assignee | ||
Comment 2•12 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsTextEquivUtils.cpp#97 Is there any way to pass nsDocAccessible* here?
Assignee | ||
Comment 3•12 years ago
|
||
Added nsDocAccessible* as argument in IDRefsIterator constructor.
Assignee: nobody → jigneshhk1992
Attachment #606883 -
Flags: feedback?(surkov.alexander)
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to Jignesh Kakadiya [:jhk] from comment #2) > http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/ > nsTextEquivUtils.cpp#97 > Is there any way to pass nsDocAccessible* here? yeah, get it from aAccessible (aAccessible->Document())
Reporter | ||
Comment 5•12 years ago
|
||
Comment on attachment 606883 [details] [diff] [review] patch Review of attachment 606883 [details] [diff] [review]: ----------------------------------------------------------------- sounds good, thanks! ::: accessible/src/base/AccIterator.h @@ +293,5 @@ > > nsString mIDs; > nsIContent* mContent; > nsAString::index_type mCurrIdx; > + nsDocAccessible* mDoc; I think Trevor will say something about memory aligning ::: accessible/src/base/nsAccessible.cpp @@ +2042,1 @@ > nsGkAtoms::aria_describedby)); fix indentation while you're here
Attachment #606883 -
Flags: review?(trev.saunders)
Attachment #606883 -
Flags: feedback?(surkov.alexander)
Attachment #606883 -
Flags: feedback+
Comment 6•12 years ago
|
||
Comment on attachment 606883 [details] [diff] [review] patch r=me with surkov's comments addressed
Attachment #606883 -
Flags: review?(trev.saunders) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Fixed indentation.
Attachment #606883 -
Attachment is obsolete: true
Reporter | ||
Comment 8•12 years ago
|
||
(In reply to alexander :surkov from comment #5) > ::: accessible/src/base/AccIterator.h > @@ +293,5 @@ > > > > nsString mIDs; > > nsIContent* mContent; > > nsAString::index_type mCurrIdx; > > + nsDocAccessible* mDoc; > > I think Trevor will say something about memory aligning what about this?
Assignee | ||
Comment 9•12 years ago
|
||
(In reply to alexander :surkov from comment #8) > (In reply to alexander :surkov from comment #5) > > ::: accessible/src/base/AccIterator.h > > @@ +293,5 @@ > > > > > > nsString mIDs; > > > nsIContent* mContent; > > > nsAString::index_type mCurrIdx; > > > + nsDocAccessible* mDoc; > > > > I think Trevor will say something about memory aligning > > what about this? I think alignment is proper similar in other files(nsAccessNode.h). Let me know if it requires more changes. thanks:)
Reporter | ||
Comment 10•12 years ago
|
||
(In reply to Jignesh Kakadiya [:jhk] from comment #9) > > what about this? > I think alignment is proper similar in other files(nsAccessNode.h). Let me > know if it requires more changes. thanks:) see bug 734566 description for example
Assignee | ||
Comment 11•12 years ago
|
||
fixed Alignment.
Attachment #607859 -
Attachment is obsolete: true
Reporter | ||
Comment 12•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/de43aa36ceef
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/de43aa36ceef
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•