Note: There are a few cases of duplicates in user autocompletion which are being worked on.

IDRefsIterator::Next() should use nsDocAccessible::GetAccessible()

RESOLVED FIXED in mozilla14

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: surkov, Assigned: jhk)

Tracking

unspecified
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
For that IDRefsIterator constructor (http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/AccIterator.h#264) should take nsDocAccessible instance.

Trevor, sounds good?
seems fine.
(Assignee)

Comment 2

5 years ago
http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsTextEquivUtils.cpp#97
Is there any way to pass nsDocAccessible* here?
(Assignee)

Comment 3

5 years ago
Created attachment 606883 [details] [diff] [review]
patch

Added nsDocAccessible* as argument in IDRefsIterator constructor.
Assignee: nobody → jigneshhk1992
Attachment #606883 - Flags: feedback?(surkov.alexander)
(Reporter)

Comment 4

5 years ago
(In reply to Jignesh Kakadiya [:jhk] from comment #2)
> http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/
> nsTextEquivUtils.cpp#97
> Is there any way to pass nsDocAccessible* here?

yeah, get it from aAccessible (aAccessible->Document())
(Reporter)

Comment 5

5 years ago
Comment on attachment 606883 [details] [diff] [review]
patch

Review of attachment 606883 [details] [diff] [review]:
-----------------------------------------------------------------

sounds good, thanks!

::: accessible/src/base/AccIterator.h
@@ +293,5 @@
>  
>    nsString mIDs;
>    nsIContent* mContent;
>    nsAString::index_type mCurrIdx;
> +  nsDocAccessible* mDoc;

I think Trevor will say something about memory aligning

::: accessible/src/base/nsAccessible.cpp
@@ +2042,1 @@
>                                          nsGkAtoms::aria_describedby));

fix indentation while you're here
Attachment #606883 - Flags: review?(trev.saunders)
Attachment #606883 - Flags: feedback?(surkov.alexander)
Attachment #606883 - Flags: feedback+
Comment on attachment 606883 [details] [diff] [review]
patch

r=me with surkov's comments addressed
Attachment #606883 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 7

5 years ago
Created attachment 607859 [details] [diff] [review]
Patch

Fixed indentation.
Attachment #606883 - Attachment is obsolete: true
(Reporter)

Comment 8

5 years ago
(In reply to alexander :surkov from comment #5)
> ::: accessible/src/base/AccIterator.h
> @@ +293,5 @@
> >  
> >    nsString mIDs;
> >    nsIContent* mContent;
> >    nsAString::index_type mCurrIdx;
> > +  nsDocAccessible* mDoc;
> 
> I think Trevor will say something about memory aligning

what about this?
(Assignee)

Comment 9

5 years ago
(In reply to alexander :surkov from comment #8)
> (In reply to alexander :surkov from comment #5)
> > ::: accessible/src/base/AccIterator.h
> > @@ +293,5 @@
> > >  
> > >    nsString mIDs;
> > >    nsIContent* mContent;
> > >    nsAString::index_type mCurrIdx;
> > > +  nsDocAccessible* mDoc;
> > 
> > I think Trevor will say something about memory aligning
> 
> what about this?
I think alignment is proper similar in other files(nsAccessNode.h). Let me know if it requires more changes. thanks:)
(Reporter)

Comment 10

5 years ago
(In reply to Jignesh Kakadiya [:jhk] from comment #9)
> > what about this?
> I think alignment is proper similar in other files(nsAccessNode.h). Let me
> know if it requires more changes. thanks:)

see bug 734566 description for example
(Assignee)

Comment 11

5 years ago
Created attachment 608583 [details] [diff] [review]
patch

fixed Alignment.
Attachment #607859 - Attachment is obsolete: true
(Reporter)

Comment 12

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/de43aa36ceef
https://hg.mozilla.org/mozilla-central/rev/de43aa36ceef
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.