Last Comment Bug 726007 - Add telemetry probes for forgetSkippable
: Add telemetry probes for forgetSkippable
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: 12 Branch
: All All
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on:
Blocks: 705582
  Show dependency treegraph
 
Reported: 2012-02-10 08:04 PST by Olli Pettay [:smaug]
Modified: 2012-02-10 16:14 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.85 KB, patch)
2012-02-10 15:11 PST, Olli Pettay [:smaug]
no flags Details | Diff | Review
-w (3.47 KB, patch)
2012-02-10 15:12 PST, Olli Pettay [:smaug]
no flags Details | Diff | Review
patch (3.88 KB, patch)
2012-02-10 15:14 PST, Olli Pettay [:smaug]
continuation: review+
Details | Diff | Review

Description Olli Pettay [:smaug] 2012-02-10 08:04:02 PST

    
Comment 1 Andrew McCreight [:mccr8] 2012-02-10 08:18:10 PST
So, I wonder what the best thing to do here is.  The most direct thing is to record every forgetSkippable.  We could also only record those above a certain length of time.
Comment 2 Olli Pettay [:smaug] 2012-02-10 15:11:41 PST
Created attachment 596186 [details] [diff] [review]
patch

I'll upload -w patch in a second
Comment 3 Olli Pettay [:smaug] 2012-02-10 15:12:59 PST
Created attachment 596187 [details] [diff] [review]
-w
Comment 4 Olli Pettay [:smaug] 2012-02-10 15:14:34 PST
Created attachment 596188 [details] [diff] [review]
patch

PRTime startTime = PR_Now(); is one line.
Comment 5 Andrew McCreight [:mccr8] 2012-02-10 15:19:41 PST
Comment on attachment 596188 [details] [diff] [review]
patch

Review of attachment 596188 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Comment 6 Olli Pettay [:smaug] 2012-02-10 16:14:56 PST
https://hg.mozilla.org/mozilla-central/rev/8b51d903ee0b

Note You need to log in before you can comment on or make changes to this bug.