Closed Bug 726054 Opened 8 years ago Closed 8 years ago

Desktop parity: track last sync time from final upload, not final fetch

Categories

(Firefox for Android :: Android Sync, defect, P1)

ARM
Android
defect

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

(Whiteboard: [qa-])

Desktop Firefox downloads records, bumping the last sync time from a record high-watermark, and then -- if an upload occurs -- bumps to the response X-Weave-Timestamp.

This, of course, is a race condition: if anyone else uploads records between starting our fetch and finishing our upload, we won't see them.

But it does avoid the problem of uploading a record and downloading it again on the next sync. So let's do this until we have sessions.
Perhaps a compromise would be to track two lastSync times, and fetch from the earlier timestamp if info/collections reports a later time than our last upload?
The alternative is to cross-session track, perhaps by querying on ID before we fetch. All nasty. Sync isn't really designed for this whole "syncing" malarkey.
https://github.com/mozilla-services/android-sync/commit/83dd5913e7ac8b72c5854e6fd002b8e6a62e6089
Blocks: 724328
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/127239d2fdb5
Assignee: nobody → rnewman
Target Milestone: --- → mozilla13
Whiteboard: [qa-]
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.