726086 - XULRunner stub looks for XUL.Framework instead of XUL.framework

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Simon Kornblith]

Attachment: Rev. 1

On OS X, the standard capitalization for the suffix of framework directories is ".framework", but the XULRunner stub appears to look for "XUL.Framework". This doesn't pose any issues on most systems, since HFS+ is case-insensitive by default, but it breaks things on case-sensitive systems unless the directory is given a capital F. The (very simple) attached patch fixes this.

Comment 1

[Matthew Gertner]

I don't have any standing to review this. You might want to ask Benjamin Smedberg. He can probably help or recommend someone who can.

Comment 2

[Ed Morley [:emorley]]

Ha, that's not actually going to do anything useful is it, doh!

Comment 3

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 596110
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=808dcd1c5160
Try run started, revision 808dcd1c5160. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=808dcd1c5160

Comment 4

[Mozilla RelEng Bot]

Try run for 808dcd1c5160 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=808dcd1c5160
Results (out of 213 total builds):
    exception: 1
    success: 179
    warnings: 19
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-808dcd1c5160

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f0f6eb03253

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7f0f6eb03253