726101 - Remote xul should be blocked in local tests, they are on the try servers

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch used to reproduce the problem

The attached file contains a test that uses a remote xul file. It runs fine locally, but when it is upped to try the test times out because remote xul is blocked (visible in the log's screenshot).

Local testing uses a temporary profile and should contain the default settings (as far as I understand). The try build tests obviously block remote XUL, so tests run locally should also do so.

Comment 1

[Boris Zbarsky [:bzbarsky]]

How are you running the test locally?  There should be no difference between local and try, as long as you're hitting our HTTP proxy...

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Boris Zbarsky (:bz) from comment #1)
> How are you running the test locally?  There should be no difference between
> local and try, as long as you're hitting our HTTP proxy...

Exactly, hence the bug report. We are on the Fx-Team repo if that helps.

How do I run the test:
$ TEST_PATH=browser/devtools/styleinspector/test/browser_bug705707_is_content_stylesheet.js make -C ff-dbg mochitest-browser-chrome

Doing this allows remote xul whilst upping to try results in a timeout and screenshot with the "This page uses unsupported technology that is no longer available in Firefox."

Of course I can toggle the property for the test but this behavior should clearly be the same locally as it is on try.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Simplified test file

The attached patch allows you to reproduce the problem. The test runs fine locally and dies when upped to try because remote xul is not allowed.

The test simply attempts to load the following uri:
http://example.com/browser/browser/base/content/test/test/browser_bug705707_is_content_stylesheet.xul

Loading this remote xul appears to work fine locally, but is blocked on the try server.

I am testing using the following URL:
TEST_PATH=browser/base/content/test/browser_bug726101_remote_xul_disabled.js make -C ff-dbg mochitest-browser-chrome

Comment 4

[Boris Zbarsky [:bzbarsky]]

This really sounds like a test harness issue, not a XUL issue.  Ted, any idea what's up here?

Comment 5

[(not currently active) Ted Mielczarek]

I don't understand at all why this wouldn't work. When we create the test profile for mochitest (or mochitest-browser-chrome), we add permission to run XUL to all the domains in server-locations.txt (except for a specific subdomain that has no XUL permission):
http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#329

We use the exact same code for running tests locally as on the try server.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I can no longer reproduce this. I guess we can put it down to try server strangeness.

If I can reproduce it I will reopen the bug.