Last Comment Bug 726115 - GC: indirect JSTraceCallback
: GC: indirect JSTraceCallback
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla13
Assigned To: Terrence Cole [:terrence]
: Jason Orendorff [:jorendorff]
Depends on: 721463
Blocks: 720522
  Show dependency treegraph
Reported: 2012-02-10 11:55 PST by Terrence Cole [:terrence]
Modified: 2012-02-16 03:07 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v1 (13.65 KB, patch)
2012-02-10 11:55 PST, Terrence Cole [:terrence]
wmccloskey: review+
Details | Diff | Splinter Review

Description User image Terrence Cole [:terrence] 2012-02-10 11:55:38 PST
Created attachment 596130 [details] [diff] [review]

It occurred to me that my indirect marking patch was going to be insanely difficult to review because of the spread-out-but-interdependent and thoroughly overlapping nature of the changes.  Thus I'm splitting it up into several non-overlapping pieces that we should be able to test and push relatively independently.  I've decided to make this the first piece since it is an interface change that touches the browser.
Comment 1 User image Bill McCloskey (:billm) 2012-02-15 16:03:12 PST
Comment on attachment 596130 [details] [diff] [review]

Review of attachment 596130 [details] [diff] [review]:

Comment 2 User image Terrence Cole [:terrence] 2012-02-15 17:33:55 PST
Comment 3 User image Marco Bonardo [::mak] 2012-02-16 03:07:43 PST

Note You need to log in before you can comment on or make changes to this bug.