Last Comment Bug 726174 - fix slow-script dialog proper
: fix slow-script dialog proper
Status: NEW
[Snappy:P2]
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: unspecified
: x86_64 Linux
: -- normal with 3 votes (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 720289
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-10 14:35 PST by Luke Wagner [:luke]
Modified: 2013-09-30 11:34 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Luke Wagner [:luke] 2012-02-10 14:35:58 PST
The slow-script dialog logic needs to be re-fixed.  Bug 699974 contained a flawed fix that needed to be backed out for the reason stated in bug 720289 comment 3.  To restate: it is possible (esp. with flash plugins) for reentrent code to permanently escape the slow-script dialog and has caused several reported hangs.

I'm not an expert in this area (clearly) but it seems that nsJSContext needs a stack, not a single field, for ctx->callbackTime so that an outer invocation is neither liberated nor hung by an inner invocation.
Comment 1 (dormant account) 2012-02-14 16:51:41 PST
Will wait on chromehang(bug 712109) to determine severity of this

Note You need to log in before you can comment on or make changes to this bug.