The default bug view has changed. See this FAQ.

get rid of search engine "used" attribute, since it causes unnecessary I/O

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Search
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Gavin, Assigned: raymondlee)

Tracking

Trunk
Firefox 15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Bug 467890 added a "used" annotation in engineMetaDataService to support tracking the first-use of default search plugins, so that we can trigger an update check. We haven't made use of that functionality (bug 511017), and in the mean time, this is causing us to hit the disk the first time a default search engine is used. and also increasing the odds of needing to write metadata, since it's the only use of the engineMetaDataService that's triggered by a common user action (simply using the search bar).

I think we should get rid of the "used" attribute for the moment. It's easy to re-introduce if we ever do end up investing in the work required to complete bug 511017.
The changeset that added it:
http://hg.mozilla.org/mozilla-central/rev/ecba698e87b5
(Assignee)

Comment 2

5 years ago
Created attachment 625906 [details] [diff] [review]
v1
Attachment #625906 - Flags: review?(gavin.sharp)
Comment on attachment 625906 [details] [diff] [review]
v1

Thanks!
Attachment #625906 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 626686 [details] [diff] [review]
Patch for checkin

Pushed to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=84b3c632fa1d
Assignee: nobody → raymond
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #625906 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
Passed Try
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/611663a9cb81
Keywords: checkin-needed
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/611663a9cb81
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.