726189 - get rid of search engine "used" attribute, since it causes unnecessary I/O

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Bug 467890 added a "used" annotation in engineMetaDataService to support tracking the first-use of default search plugins, so that we can trigger an update check. We haven't made use of that functionality (bug 511017), and in the mean time, this is causing us to hit the disk the first time a default search engine is used. and also increasing the odds of needing to write metadata, since it's the only use of the engineMetaDataService that's triggered by a common user action (simply using the search bar).

I think we should get rid of the "used" attribute for the moment. It's easy to re-introduce if we ever do end up investing in the work required to complete bug 511017.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The changeset that added it:
http://hg.mozilla.org/mozilla-central/rev/ecba698e87b5

Comment 2

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 625906 [details] [diff] [review]
v1

Thanks!

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Pushed to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=84b3c632fa1d

Comment 5

[Raymond Lee [:raymondlee]]

Passed Try

Comment 6

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/611663a9cb81

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/611663a9cb81