Closed Bug 726189 Opened 10 years ago Closed 9 years ago

get rid of search engine "used" attribute, since it causes unnecessary I/O

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 15

People

(Reporter: Gavin, Assigned: raymondlee)

Details

Attachments

(1 file, 1 obsolete file)

Bug 467890 added a "used" annotation in engineMetaDataService to support tracking the first-use of default search plugins, so that we can trigger an update check. We haven't made use of that functionality (bug 511017), and in the mean time, this is causing us to hit the disk the first time a default search engine is used. and also increasing the odds of needing to write metadata, since it's the only use of the engineMetaDataService that's triggered by a common user action (simply using the search bar).

I think we should get rid of the "used" attribute for the moment. It's easy to re-introduce if we ever do end up investing in the work required to complete bug 511017.
Attached patch v1 (obsolete) — Splinter Review
Attachment #625906 - Flags: review?(gavin.sharp)
Comment on attachment 625906 [details] [diff] [review]
v1

Thanks!
Attachment #625906 - Flags: review?(gavin.sharp) → review+
Pushed to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=84b3c632fa1d
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #625906 - Attachment is obsolete: true
Passed Try
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/611663a9cb81
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.