Last Comment Bug 726210 - IonMonkey: add various push functions to ARM
: IonMonkey: add various push functions to ARM
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: ARM Linux
: -- normal (vote)
: ---
Assigned To: general
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-10 15:56 PST by Marty Rosenberg [:mjrosenb]
Modified: 2012-02-17 19:49 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
/home/mrosenberg/patches/addPushes-r0.patch (4.53 KB, patch)
2012-02-10 15:56 PST, Marty Rosenberg [:mjrosenb]
no flags Details | Diff | Review
/home/mrosenberg/patches/addPushes-r1.patch (5.24 KB, patch)
2012-02-10 16:08 PST, Marty Rosenberg [:mjrosenb]
cdleary: review+
Details | Diff | Review

Description Marty Rosenberg [:mjrosenb] 2012-02-10 15:56:03 PST
Created attachment 596204 [details] [diff] [review]
/home/mrosenberg/patches/addPushes-r0.patch

presently NYI's.  The implementation is pretty straightforward.  One catch: vstr/vldr don't have an update mechanism, so I'm forced to use the store multiple/load multiple variants.  There was also a bug where the mode (up, down) of the store was not recorded.
Comment 1 Marty Rosenberg [:mjrosenb] 2012-02-10 16:08:54 PST
Created attachment 596211 [details] [diff] [review]
/home/mrosenberg/patches/addPushes-r1.patch

whoops, the definition of vpush and vpop was in a later patch.
Comment 2 Chris Leary [:cdleary] (not checking bugmail) 2012-02-13 14:56:28 PST
Comment on attachment 596211 [details] [diff] [review]
/home/mrosenberg/patches/addPushes-r1.patch

Review of attachment 596211 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay for just tiny nits! :-P

::: js/src/ion/arm/MacroAssembler-arm.cpp
@@ +870,5 @@
> +MacroAssemblerARM::ma_vpop(VFPRegister r)
> +{
> +        startFloatTransferM(IsLoad, sp, IA, WriteBack);
> +        transferFloatReg(r);
> +        finishFloatTransfer();

Nit: double indented?

@@ +1841,5 @@
>      // when we return from this call, sp will be its present value minus 4.
> +    Label foo;
> +    as_b(&foo);
> +    as_bkpt();
> +    bind(&foo);

Branching over a breakpoint -- did you want to leave this in?

Note You need to log in before you can comment on or make changes to this bug.