Closed
Bug 726210
Opened 12 years ago
Closed 12 years ago
IonMonkey: add various push functions to ARM
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mjrosenb, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
5.24 KB,
patch
|
cdleary
:
review+
|
Details | Diff | Splinter Review |
presently NYI's. The implementation is pretty straightforward. One catch: vstr/vldr don't have an update mechanism, so I'm forced to use the store multiple/load multiple variants. There was also a bug where the mode (up, down) of the store was not recorded.
Attachment #596204 -
Flags: review?(christopher.leary)
Reporter | ||
Comment 1•12 years ago
|
||
whoops, the definition of vpush and vpop was in a later patch.
Attachment #596204 -
Attachment is obsolete: true
Attachment #596204 -
Flags: review?(christopher.leary)
Attachment #596211 -
Flags: review?(christopher.leary)
Comment 2•12 years ago
|
||
Comment on attachment 596211 [details] [diff] [review] /home/mrosenberg/patches/addPushes-r1.patch Review of attachment 596211 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay for just tiny nits! :-P ::: js/src/ion/arm/MacroAssembler-arm.cpp @@ +870,5 @@ > +MacroAssemblerARM::ma_vpop(VFPRegister r) > +{ > + startFloatTransferM(IsLoad, sp, IA, WriteBack); > + transferFloatReg(r); > + finishFloatTransfer(); Nit: double indented? @@ +1841,5 @@ > // when we return from this call, sp will be its present value minus 4. > + Label foo; > + as_b(&foo); > + as_bkpt(); > + bind(&foo); Branching over a breakpoint -- did you want to leave this in?
Attachment #596211 -
Flags: review?(christopher.leary) → review+
Reporter | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•