Closed Bug 726259 Opened 8 years ago Closed 8 years ago

bookmarks toolbar top border

Categories

(Firefox :: Theme, defect, trivial)

11 Branch
All
Windows 7
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 13

People

(Reporter: yang.pohsiang, Assigned: soapy)

Details

Attachments

(2 files, 1 obsolete file)

Attached image Firefox Bug.png
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0
Build ID: 20120201153158

Steps to reproduce:

Condition: bookmarks toolbar only, and tabs on top, in window mode.


Actual results:

 It has no border on the top of bookmarks toolbar, and make the bookmarks item cut (1px).



Expected results:

It should like the appearance in maxmized window. I consider it is a appearance bug.
Severity: normal → trivial
Component: Untriaged → Theme
Summary: bookmarks toolbar → bookmarks toolbar top border
This should be fixed by the patch in bug 727650.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → soapyhamhocks
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #598202 - Flags: review?(dao)
Comment on attachment 598202 [details] [diff] [review]
Patch v1

nit: [tabsontop=true] instead of [tabsontop="true"]

I'd also prefer if you left :not([customizing]) on #nav-bar rather than #navigator-toolbox.
Attachment #598202 - Flags: review?(dao) → review+
No longer depends on: australis-navbar
Attached patch Patch v2Splinter Review
Attachment #598202 - Attachment is obsolete: true
Attachment #598501 - Flags: review?(dao)
Comment on attachment 598501 [details] [diff] [review]
Patch v2

Thanks!
Attachment #598501 - Flags: review?(dao) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/841f33bf35ef
Status: NEW → ASSIGNED
Keywords: checkin-needed
Hardware: x86_64 → All
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/mozilla-central/rev/841f33bf35ef
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
QA Contact: untriaged → theme
You need to log in before you can comment on or make changes to this bug.