726270 - java.lang.NullPointerException: at android.widget.CursorTreeAdapter.setChildrenCursor(CursorTreeAdapter.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Scoobidiver (away)]

This crash first appeared in 13.a1/20120209 and has been hit by 4 users.

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A%20at%20android.widget.CursorTreeAdapter.setChildrenCursor%28CursorTreeAdapter.java%29

Comment 1

[:Margaret Leibovic]

This sounds like it may be a regression from bug 716918, but other patches have landed touching that code since then. Is there a way to get a java stack?

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

"java.lang.NullPointerException
	at android.widget.CursorTreeAdapter.setChildrenCursor(CursorTreeAdapter.java:165)
	at org.mozilla.gecko.AwesomeBarTabs$RefreshChildrenCursorTask.onPostExecute(AwesomeBarTabs.java:224)
	at org.mozilla.gecko.AwesomeBarTabs$RefreshChildrenCursorTask.onPostExecute(AwesomeBarTabs.java:203)
	at android.os.AsyncTask.finish(AsyncTask.java:417)
	at android.os.AsyncTask.access$300(AsyncTask.java:127)
	at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:429)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at org.mozilla.gecko.GeckoApp$32.run(GeckoApp.java:1783)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3728)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:864)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:622)
	at dalvik.system.NativeStart.main(Native Method)

Comment 3

[:Margaret Leibovic]

Lucas, is it possible that childrenCursor can be null here?

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AwesomeBarTabs.java#224

Comment 4

[Scoobidiver (away)]

It's #3 top crasher in 13.0a1 and #1 without fixed crashers.

The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4b9608fd670c&tochange=7c0ba1c98ff7
bug 716918 belongs to this range. Let's mark this bug as a regression from it.

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Margaret Leibovic [:margaret] from comment #3)
> Lucas, is it possible that childrenCursor can be null here?
> 
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/
> AwesomeBarTabs.java#224

Nope. The only reason childrenCursor would be null here is when getDesktopBookmarks() returns null. Maybe double check for edge cases on the query itself?

Comment 6

[:Margaret Leibovic]

This crash will go away when bug 722020 lands, since we won't be using a CursorTreeAdapter anymore. Hopefully we can finish that soon.

Comment 8

[:Margaret Leibovic]

I'm marking this as FIXED, since this code is gone now that bug 722020 landed.