Closed
Bug 726369
Opened 13 years ago
Closed 13 years ago
Make the circular buffer reader code safer.
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.46 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #596399 -
Flags: review?(bgirard)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 596399 [details] [diff] [review]
Make the circular buffer reader code safer.
Patch is missing, headers only
Attachment #596399 -
Flags: review?(bgirard)
|
Assignee | |
Comment 2•13 years ago
|
||
A more reviewable version.
Attachment #596399 -
Attachment is obsolete: true
Attachment #596407 -
Flags: review?(bgirard)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 596407 [details] [diff] [review]
A more reviewable version.
Review of attachment 596407 [details] [diff] [review]:
-----------------------------------------------------------------
r+ with this changed
::: tools/profiler/TableTicker.cpp
@@ -280,1 +277,1 @@
> > while (mReadPos != mLastFlushPos) {
Infinite loop: mReadPos -> readPos
Attachment #596407 -
Flags: review?(bgirard) → review+
|
||
Comment 4•13 years ago
|
||
Comment on attachment 596407 [details] [diff] [review]
A more reviewable version.
> profile.Append(mEntries[mReadPos].TagToString(this).c_str());
This mReadPos needs to be changed, too.
|
|
||
Comment 5•13 years ago
|
||
Fixed my and Markus' comments.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d223a5698a08
Assignee: nobody → jmuizelaar
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•