726369 - Make the circular buffer reader code safer.

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Make the circular buffer reader code safer.

Comment 1

[Benoit Girard (:BenWa)]

Comment on attachment 596399 [details] [diff] [review]
Make the circular buffer reader code safer.

Patch is missing, headers only

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: A more reviewable version.

A more reviewable version.

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 596407 [details] [diff] [review]
A more reviewable version.

Review of attachment 596407 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with this changed

::: tools/profiler/TableTicker.cpp
@@ -280,1 +277,1 @@
> >      while (mReadPos != mLastFlushPos) {

Infinite loop: mReadPos -> readPos

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 596407 [details] [diff] [review]
A more reviewable version.

>       profile.Append(mEntries[mReadPos].TagToString(this).c_str());

This mReadPos needs to be changed, too.

Comment 5

[Benoit Girard (:BenWa)]

Fixed my and Markus' comments.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d223a5698a08

Comment 6

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/mozilla-central/rev/d223a5698a08