Closed Bug 726402 Opened 12 years ago Closed 12 years ago

Intermittent test_bug369370.html | image width - got 400, expected 378, | image height - got 300, expected 284

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla13

People

(Reporter: philor, Assigned: fryn)

References

Details

(Keywords: intermittent-failure, Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

patch
3.01 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=9271244&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound pgo test mochitests-1/5 on 2012-02-11 18:38:20 PST for push 7e3d5c2879a8

74720 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | looking for imagedoc img - 1 should equal 1
74721 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | Checking doc width - 400 should equal 400
74722 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | Checking doc height - 300 should equal 300
74723 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug369370.html | image width - got 400, expected 378
74724 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug369370.html | image height - got 300, expected 284
74725 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | Checking scrollLeft - 0 should equal 0
74726 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | Checking scrollTop - 0 should equal 0
74727 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | ----- click 1 -----
74728 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | image width - 800 should equal 800
74729 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | image height - 600 should equal 600
74730 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | Checking scrollLeft - 0 should equal 0
74731 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | Checking scrollTop - 0 should equal 0
74732 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | ----- click 2 -----
74733 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug369370.html | image width - got 400, expected 378
74734 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug369370.html | image height - got 300, expected 284
74735 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | Checking scrollLeft - 0 should equal 0
74736 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | Checking scrollTop - 0 should equal 0
74737 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | ----- click 3 -----
74738 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | image width - 800 should equal 800
74739 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | image height - 600 should equal 600
74740 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | Checking scrollLeft - 400 should equal 400
74741 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | Checking scrollTop - 300 should equal 300
74742 INFO TEST-PASS | /tests/content/html/document/test/test_bug369370.html | ----- click 4 -----
74743 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug369370.html | image width - got 400, expected 378
74744 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug369370.html | image height - got 300, expected 284
Depends on: 717143
Assignee: nobody → fryn
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: x86 → All
Attached patch patch — — Splinter Review 
Since the patch for bug 717143 removes the bogus margins, I've updated the test, and it will no longer be intermittent after landing this patch together with that patch.
Attachment #598516 - Flags: review?(bzbarsky)
Comment on attachment 598516 [details] [diff] [review]
patch

r=me
Attachment #598516 - Flags: review?(bzbarsky) → review+
Thanks for the review.

The try run with this patch came up all green:
https://people.mozilla.com/~fyan/tmp/fiximagesizing-tryserver.png

https://hg.mozilla.org/integration/fx-team/rev/9fd32eed57f8
Whiteboard: [orange] → [orange][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9fd32eed57f8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Whiteboard: [orange][fixed-in-fx-team] → [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: