726416 - Fix some content/ build warnings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Mounir Lamouri (:mounir)]

Comment on attachment 596447 [details] [diff] [review]
Patch v1

Review of attachment 596447 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comment addressed

::: content/media/nsBuiltinDecoder.cpp
@@ +326,5 @@
>    // http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#seeking
>    PRInt32 range = 0;
>    if (!IsInRanges(seekable, aTime, range)) {
>      if (range != -1) {
> +      if (PRUint32(range + 1) < length) {

Could you just add a comment saying that |range + 1| can't be negative because |range| minimal value is -1? Otherwise, that conversion would be dangerous.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/254285dbf954