Fix some content/ build warnings

RESOLVED FIXED in mozilla13

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 596447 [details] [diff] [review]
Patch v1
Attachment #596447 - Flags: review?(mounir)
Comment on attachment 596447 [details] [diff] [review]
Patch v1

Review of attachment 596447 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comment addressed

::: content/media/nsBuiltinDecoder.cpp
@@ +326,5 @@
>    // http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#seeking
>    PRInt32 range = 0;
>    if (!IsInRanges(seekable, aTime, range)) {
>      if (range != -1) {
> +      if (PRUint32(range + 1) < length) {

Could you just add a comment saying that |range + 1| can't be negative because |range| minimal value is -1? Otherwise, that conversion would be dangerous.
Attachment #596447 - Flags: review?(mounir) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/254285dbf954
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.