The default bug view has changed. See this FAQ.

FILE_FLAG_SEQUENTIAL_SCAN always being passed for all file IO

RESOLVED FIXED in mozilla13

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

unspecified
mozilla13
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 596552 [details] [diff] [review]
Patch v1.

We're currently always passing the read-ahead flag (FILE_FLAG_SEQUENTIAL_SCAN) on Windows for every file operation.

This flag causes 1) old pages to be released faster and 2) extra data to be read before it is needed (if it is needed).
This is good in a lot of cases, but we should only use it when it is needed and when the flag is actually set.

I think it was unintentionally always turned on in October of 2011 in Bug 686691.
Attachment #596552 - Flags: review?(benjamin)
(Assignee)

Updated

5 years ago
Blocks: 686691

Comment 1

5 years ago
Comment on attachment 596552 [details] [diff] [review]
Patch v1.

Good catch
Attachment #596552 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/4e0b3a431e2e
https://hg.mozilla.org/mozilla-central/rev/4e0b3a431e2e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.