HTML and XUL accessible classes shouldn't use nsAccessibilityService::GetAccessible

RESOLVED FIXED in mozilla13

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: joseph)

Tracking

({access})

unspecified
mozilla13
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
search through html and xul folders (http://mxr.mozilla.org/mozilla-central/source/accessible/src/) for GetAccService()->GetAccessible( and replace all calls on mDoc->GetAccessible(
(Reporter)

Updated

5 years ago
Blocks: 725572
No longer blocks: 389800
(Assignee)

Comment 1

5 years ago
Created attachment 596950 [details] [diff] [review]
First version of patch.
Attachment #596950 - Flags: review?(surkov.alexander)
(Reporter)

Comment 2

5 years ago
Comment on attachment 596950 [details] [diff] [review]
First version of patch.

Review of attachment 596950 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ +436,5 @@
>      content = content->GetParent();
>    }
>  
>    if (content) {
> +    nsAccessible* selAcc = mDoc->GetAccessible(content, nsnull);

nsDocAccessible doesn't take two arguments
Attachment #596950 - Flags: review?(surkov.alexander) → review-
(Reporter)

Updated

5 years ago
Assignee: nobody → joey.blacksmith
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Created attachment 596994 [details] [diff] [review]
Patch - Second version
Attachment #596950 - Attachment is obsolete: true
Attachment #596994 - Flags: review?(surkov.alexander)
(Reporter)

Comment 4

5 years ago
Comment on attachment 596994 [details] [diff] [review]
Patch - Second version

Review of attachment 596994 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #596994 - Flags: review?(surkov.alexander) → review+
(Reporter)

Comment 5

5 years ago
inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/785130198c91
https://hg.mozilla.org/mozilla-central/rev/785130198c91
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.