Last Comment Bug 726507 - HTML and XUL accessible classes shouldn't use nsAccessibilityService::GetAccessible
: HTML and XUL accessible classes shouldn't use nsAccessibilityService::GetAcce...
Status: RESOLVED FIXED
[good first bug][mentor=surkov.alexan...
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla13
Assigned To: joseph
:
Mentors:
Depends on:
Blocks: 725572
  Show dependency treegraph
 
Reported: 2012-02-12 20:01 PST by alexander :surkov
Modified: 2012-02-15 09:16 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
First version of patch. (3.20 KB, patch)
2012-02-14 02:21 PST, joseph
surkov.alexander: review-
Details | Diff | Splinter Review
Patch - Second version (3.17 KB, patch)
2012-02-14 06:09 PST, joseph
surkov.alexander: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-02-12 20:01:35 PST
search through html and xul folders (http://mxr.mozilla.org/mozilla-central/source/accessible/src/) for GetAccService()->GetAccessible( and replace all calls on mDoc->GetAccessible(
Comment 1 joseph 2012-02-14 02:21:32 PST
Created attachment 596950 [details] [diff] [review]
First version of patch.
Comment 2 alexander :surkov 2012-02-14 04:21:42 PST
Comment on attachment 596950 [details] [diff] [review]
First version of patch.

Review of attachment 596950 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ +436,5 @@
>      content = content->GetParent();
>    }
>  
>    if (content) {
> +    nsAccessible* selAcc = mDoc->GetAccessible(content, nsnull);

nsDocAccessible doesn't take two arguments
Comment 3 joseph 2012-02-14 06:09:39 PST
Created attachment 596994 [details] [diff] [review]
Patch - Second version
Comment 4 alexander :surkov 2012-02-14 17:38:05 PST
Comment on attachment 596994 [details] [diff] [review]
Patch - Second version

Review of attachment 596994 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Comment 5 alexander :surkov 2012-02-14 22:20:53 PST
inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/785130198c91
Comment 6 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-02-15 09:16:48 PST
https://hg.mozilla.org/mozilla-central/rev/785130198c91

Note You need to log in before you can comment on or make changes to this bug.