Closed Bug 726507 Opened 8 years ago Closed 8 years ago

HTML and XUL accessible classes shouldn't use nsAccessibilityService::GetAccessible

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: surkov, Assigned: joey.blacksmith)

References

Details

(Keywords: access, Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 file, 1 obsolete file)

search through html and xul folders (http://mxr.mozilla.org/mozilla-central/source/accessible/src/) for GetAccService()->GetAccessible( and replace all calls on mDoc->GetAccessible(
Blocks: 725572
No longer blocks: cleana11y
Attached patch First version of patch. (obsolete) — Splinter Review
Attachment #596950 - Flags: review?(surkov.alexander)
Comment on attachment 596950 [details] [diff] [review]
First version of patch.

Review of attachment 596950 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ +436,5 @@
>      content = content->GetParent();
>    }
>  
>    if (content) {
> +    nsAccessible* selAcc = mDoc->GetAccessible(content, nsnull);

nsDocAccessible doesn't take two arguments
Attachment #596950 - Flags: review?(surkov.alexander) → review-
Assignee: nobody → joey.blacksmith
Status: NEW → ASSIGNED
Attachment #596950 - Attachment is obsolete: true
Attachment #596994 - Flags: review?(surkov.alexander)
Comment on attachment 596994 [details] [diff] [review]
Patch - Second version

Review of attachment 596994 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #596994 - Flags: review?(surkov.alexander) → review+
https://hg.mozilla.org/mozilla-central/rev/785130198c91
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.