726573 - Change .hgignore and .gitignore to ignore Eclipse IDE project files in subdirectories, too

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Till Schneidereit [:till]]

Attachment: patch, V1

In bug 718442, jwatts added Eclipse IDE project files in the root directory to VCS ignore files. I don't really know about other modules but at least for SpiderMonkey it makes sense to create an Eclipse project rooted in js.

The attached patch ignored the files and directory Eclipse creates in all subdirectories. Should that not be desirable, I will add patterns for specific locations instead.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 596665 [details] [diff] [review]
patch, V1

Review of attachment 596665 [details] [diff] [review]:
-----------------------------------------------------------------

::: .hgignore
@@ +42,5 @@
>  
>  # Ignore the files and directory that Eclipse IDE creates
> +\.project$
> +\.cproject$
> +\.settings$

Hmm, how come there's no trailing '/' on .settings here?

Comment 2

[Till Schneidereit [:till]]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #1)
> Hmm, how come there's no trailing '/' on .settings here?

Good question. It used to work and still does. I suppose adding the '/' makes sense to prevent weird differences between what git and hg ignore, respectively.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 596665 [details] [diff] [review]
patch, V1

Review of attachment 596665 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that change made

Thanks!

Comment 4

[Till Schneidereit [:till]]

Attachment: patch, V2, carrying r+

Changed .hgignore to only ignore directories called ".settings", not files.

Thanks for the review!

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f78a0dea88fc

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/f78a0dea88fc