Closed Bug 726573 Opened 8 years ago Closed 8 years ago

Change .hgignore and .gitignore to ignore Eclipse IDE project files in subdirectories, too

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla13

People

(Reporter: till, Assigned: till)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch, V1 (obsolete) — Splinter Review
In bug 718442, jwatts added Eclipse IDE project files in the root directory to VCS ignore files. I don't really know about other modules but at least for SpiderMonkey it makes sense to create an Eclipse project rooted in js.

The attached patch ignored the files and directory Eclipse creates in all subdirectories. Should that not be desirable, I will add patterns for specific locations instead.
Attachment #596665 - Flags: review?(khuey)
Comment on attachment 596665 [details] [diff] [review]
patch, V1

Review of attachment 596665 [details] [diff] [review]:
-----------------------------------------------------------------

::: .hgignore
@@ +42,5 @@
>  
>  # Ignore the files and directory that Eclipse IDE creates
> +\.project$
> +\.cproject$
> +\.settings$

Hmm, how come there's no trailing '/' on .settings here?
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #1)
> Hmm, how come there's no trailing '/' on .settings here?

Good question. It used to work and still does. I suppose adding the '/' makes sense to prevent weird differences between what git and hg ignore, respectively.
Comment on attachment 596665 [details] [diff] [review]
patch, V1

Review of attachment 596665 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that change made

Thanks!
Attachment #596665 - Flags: review?(khuey) → review+
Changed .hgignore to only ignore directories called ".settings", not files.

Thanks for the review!
Attachment #596665 - Attachment is obsolete: true
Attachment #596678 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/f78a0dea88fc
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/f78a0dea88fc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.