Last Comment Bug 726573 - Change .hgignore and .gitignore to ignore Eclipse IDE project files in subdirectories, too
: Change .hgignore and .gitignore to ignore Eclipse IDE project files in subdir...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla13
Assigned To: Till Schneidereit [:till]
:
Mentors:
Depends on: 718442
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-13 06:10 PST by Till Schneidereit [:till]
Modified: 2012-02-14 02:33 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch, V1 (842 bytes, patch)
2012-02-13 06:10 PST, Till Schneidereit [:till]
khuey: review+
Details | Diff | Review
patch, V2, carrying r+ (843 bytes, patch)
2012-02-13 06:55 PST, Till Schneidereit [:till]
till: review+
Details | Diff | Review

Description Till Schneidereit [:till] 2012-02-13 06:10:05 PST
Created attachment 596665 [details] [diff] [review]
patch, V1

In bug 718442, jwatts added Eclipse IDE project files in the root directory to VCS ignore files. I don't really know about other modules but at least for SpiderMonkey it makes sense to create an Eclipse project rooted in js.

The attached patch ignored the files and directory Eclipse creates in all subdirectories. Should that not be desirable, I will add patterns for specific locations instead.
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-02-13 06:41:14 PST
Comment on attachment 596665 [details] [diff] [review]
patch, V1

Review of attachment 596665 [details] [diff] [review]:
-----------------------------------------------------------------

::: .hgignore
@@ +42,5 @@
>  
>  # Ignore the files and directory that Eclipse IDE creates
> +\.project$
> +\.cproject$
> +\.settings$

Hmm, how come there's no trailing '/' on .settings here?
Comment 2 Till Schneidereit [:till] 2012-02-13 06:44:30 PST
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #1)
> Hmm, how come there's no trailing '/' on .settings here?

Good question. It used to work and still does. I suppose adding the '/' makes sense to prevent weird differences between what git and hg ignore, respectively.
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-02-13 06:45:09 PST
Comment on attachment 596665 [details] [diff] [review]
patch, V1

Review of attachment 596665 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that change made

Thanks!
Comment 4 Till Schneidereit [:till] 2012-02-13 06:55:33 PST
Created attachment 596678 [details] [diff] [review]
patch, V2, carrying r+

Changed .hgignore to only ignore directories called ".settings", not files.

Thanks for the review!
Comment 5 Daniel Holbert [:dholbert] 2012-02-13 14:37:35 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/f78a0dea88fc
Comment 6 Marco Bonardo [::mak] 2012-02-14 02:33:02 PST
https://hg.mozilla.org/mozilla-central/rev/f78a0dea88fc

Note You need to log in before you can comment on or make changes to this bug.