726741 - We leak nsPluginInstanceOwner for every plugin instance on ICS

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

In a few ANP interfaces, we request the nsPluginInstanceOwner* via nsNPAPIPluginInstance::GetOwner. GetOwner() refs the return, but we don't explicitly unref or use nsRefPtr, and the object is leaked later when the plugin instance is destroyed.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Don't leak nsPluginInstanceOwner on Android

Comment 2

[Josh Aas]

Comment on attachment 596751 [details] [diff] [review]
Don't leak nsPluginInstanceOwner on Android

Review of attachment 596751 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/base/android/ANPVideo.cpp
@@ +42,5 @@
> +}
> +
> +static AndroidMediaLayer* GetLayerForInstance(NPP instance) {
> +  nsRefPtr<nsPluginInstanceOwner> owner;
> +  if (NS_FAILED(GetOwner(instance, getter_AddRefs(owner))))

I prefer always having braces for if blocks.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f086b7e2de8a

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/f086b7e2de8a