Last Comment Bug 726794 - Nonexistent macro WTF_PLATFORM_LINUX used in MacroAssemblerARM.cpp instead of WTF_OS_LINUX
: Nonexistent macro WTF_PLATFORM_LINUX used in MacroAssemblerARM.cpp instead of...
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: David Mandelin [:dmandelin]
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-02-13 14:46 PST by Philip Taylor
Modified: 2012-03-17 17:25 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (1.45 KB, patch)
2012-03-16 13:15 PDT, David Mandelin [:dmandelin]
dvander: review+
Details | Diff | Splinter Review

Description Philip Taylor 2012-02-13 14:46:50 PST
Bug 625600 renamed WTF_PLATFORM_LINUX to WTF_OS_LINUX, but js/src/assembler/assembler/MacroAssemblerARM.cpp still uses WTF_PLATFORM_LINUX in isVFPPresent() for checking /proc/self/auxv, so that code will never get built.

js/src/assembler/wtf/Assertions.h also seems to use some macros that were renamed (WTF_PLATFORM_SYMBIAN, WTF_PLATFORM_WIN_OS) but I have no idea whether that matters at all.
Comment 1 David Mandelin [:dmandelin] 2012-03-16 13:15:07 PDT
Created attachment 606700 [details] [diff] [review]

Thanks for the catch.
Comment 2 David Mandelin [:dmandelin] 2012-03-16 13:19:40 PDT
Wow, fast review! :-D I'm running it on try for build bustage paranoia.
Comment 3 David Mandelin [:dmandelin] 2012-03-16 17:05:34 PDT
Comment 4 Phil Ringnalda (:philor) 2012-03-17 17:25:17 PDT

Note You need to log in before you can comment on or make changes to this bug.