Nonexistent macro WTF_PLATFORM_LINUX used in MacroAssemblerARM.cpp instead of WTF_OS_LINUX

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Philip Taylor, Assigned: dmandelin)

Tracking

Trunk
mozilla14
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Bug 625600 renamed WTF_PLATFORM_LINUX to WTF_OS_LINUX, but js/src/assembler/assembler/MacroAssemblerARM.cpp still uses WTF_PLATFORM_LINUX in isVFPPresent() for checking /proc/self/auxv, so that code will never get built.

js/src/assembler/wtf/Assertions.h also seems to use some macros that were renamed (WTF_PLATFORM_SYMBIAN, WTF_PLATFORM_WIN_OS) but I have no idea whether that matters at all.
(Assignee)

Comment 1

6 years ago
Created attachment 606700 [details] [diff] [review]
Patch

Thanks for the catch.
Assignee: general → dmandelin
Attachment #606700 - Flags: review?(dvander)
Attachment #606700 - Flags: review?(dvander) → review+
(Assignee)

Comment 2

6 years ago
Wow, fast review! :-D I'm running it on try for build bustage paranoia.
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/7a7f8fbd62d8
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/7a7f8fbd62d8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.