726873 - Setting window.fullScreen to true makes Fennec full screen, but there should be a way to get out of it

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

Steps to reproduce:
- Tap on the window.fullScreen = true button

Notice how the browser is now in full screen mode, but there is no way to get out of it. Unless you tap on the window.fullScreen = false button.
There should be a way from inside the browser to get out of full screen mode.

With the element.mozRequestFullScreen method, the Android back button is used to get out of full screen, so I guess that should also be used for this case.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I thought Matt or Margaret fixed a similar sounding bug. Maybe it was part of the changes that Matt made for the Fullscreen add-on.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

F11 works on desktop to get out of fullScreen mode. Makes sense that BACK on Android should do it too.

Comment 3

[Matt Brubeck (:mbrubeck)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> F11 works on desktop to get out of fullScreen mode. Makes sense that BACK on
> Android should do it too.

But this would leave you without a way to navigate back in history.  If you enter fullscreen mode by toggling the preference, just toggle it again to exit.  The "Full Screen" add-on provides a menu item if you want a way to do this in the UI: https://addons.mozilla.org/en-US/android/addon/full-screen-252573/

Comment 4

[Matt Brubeck (:mbrubeck)]

Sorry, I didn't realize it was possible to set this from content...  We should either disallow that by default, or provide in-browser UI to reset it.

Comment 5

[Matt Brubeck (:mbrubeck)]

Fixed by bug 727303.

Comment 6

[Paul Feher]

 I don't have permission to see bug 727303. This should be verified by someone who has access to it.